Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heading in footer section #890

Open
SaptakS opened this issue Aug 25, 2021 · 0 comments
Open

Heading in footer section #890

SaptakS opened this issue Aug 25, 2021 · 0 comments

Comments

@SaptakS
Copy link
Contributor

SaptakS commented Aug 25, 2021

While doing HTML validation PR, I found out that the heading <h2> in footer section had richtext inside it. By HTML standards, a heading tag can only have phrase content as a child.

I think (and as also suggested by @chigby in #885 (comment)) there are two different solutions:

  1. We split into fields like footer heading, footer_organization_link, etc?
  2. Decide if this at all needs to be a heading. If it's just a big text visually, and we don't want to convey the same to the assistive tech users and it doesn't really matter in the content-flow, then we can just style it as normal div and remove role=heading and aria-levels

Refs #885

@soleilera soleilera added someday and removed someday labels Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants