Apply suggestions from code review

Co-authored-by: Copilot <[email protected]>

Author: cfm

API2.md

@@ -181,7 +181,7 @@ state "Cache and report success" as SuccessBranch {
     OK --> UpdateCache
     MultiStatus --> UpdateCache
 
-    UpdateCache : redis.set(event.id, OK, ttl)
+    UpdateCache : redis.set(event.id, status, ttl)
     UpdateCache --> [*] : return (OK, delta)
 }
 

securedrop/journalist_app/api2/events.py

@@ -187,7 +187,7 @@ def handle_source_deleted(event: Event, minor: int) -> EventResult:
         except ValueError as exc:
             return EventResult(
                 event_id=event.id,
-                status=(EventStatusCode.InternalServerError, exc),
+                status=(EventStatusCode.InternalServerError, str(exc)),
             )
 
     @staticmethod
@@ -333,9 +333,11 @@ def handle_source_conversation_truncated(event: Event, minor: int) -> EventResul
         else:
             status = EventStatusCode.OK
 
+        db.session.refresh(source)
         return EventResult(
             event_id=event.id,
             status=(status, None),
+            sources={source.uuid: source},
             items=deleted,
         )
 

securedrop/journalist_app/api2/types.py

@@ -155,6 +155,9 @@ class SourceConversationTruncatedData(EventData):
     # up to and including n".
     upper_bound: int
 
+    def __post_init__(self) -> None:
+        if self.upper_bound < 0:
+            raise ValueError("upper_bound must be non-negative")
 
 EVENT_DATA_TYPES = {
     EventType.REPLY_SENT: ReplySentData,