Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency stringcase seems to be unmaintained #1655

Closed
pierrecamilleri opened this issue Apr 29, 2024 · 2 comments · Fixed by #1727
Closed

Dependency stringcase seems to be unmaintained #1655

pierrecamilleri opened this issue Apr 29, 2024 · 2 comments · Fixed by #1727

Comments

@pierrecamilleri
Copy link
Collaborator

pierrecamilleri commented Apr 29, 2024 •
edited
Loading

Context

Frictionless has stringcase as a dependency.

From what I can see, it is used for conversion of strings to snakecase or camelcase.

Issue

The stringcase dependency seems not maintained anymore.

It triggers for instance DepreciationWarnings :

python3.9/site-packages/stringcase.py:247: DeprecationWarning: invalid escape sequence \W
return re.sub("\W+", "", string)

Proposition

I would either remove the dependency and include all code to perform this in frictionless-py, or use the Casefy alternative replacement of this library.

Do you have a preferred option? I can propose a Pull Request.
@pierrecamilleri pierrecamilleri changed the title Dependency stringcase seem to be unmaintained Dependency stringcase seems to be unmaintained Apr 29, 2024
@LincolnPuzey
Copy link
Contributor

I had a look into this - given that stringcase is also MIT-licensed, and to be sure of not changing behavior in frictionless, I would suggest copying the functions we use into frictionless as-is. And then fixing any deprecations.

Happy to open a PR if that sounds ok

@pierrecamilleri
Copy link
Collaborator Author

Sounds good to me, thanks !

Lincoln-GR pushed a commit to LincolnPuzey/frictionless-py that referenced this issue Jan 16, 2025
@LincolnPuzey
frictionlessdata#1655 Vendor the stringcase library which appears to …
dd47055 
…unmaintained
Lincoln-GR pushed a commit to LincolnPuzey/frictionless-py that referenced this issue Jan 16, 2025
@LincolnPuzey
frictionlessdata#1655 Make string raw string to fix Deprecation warning
e9bad00
Lincoln-GR pushed a commit to LincolnPuzey/frictionless-py that referenced this issue Jan 16, 2025
@LincolnPuzey
frictionlessdata#1655 Swap stringcase dependency for the vendored pac…
50e7185 
…kage
@LincolnPuzey LincolnPuzey mentioned this issue Jan 16, 2025
Merged
pierrecamilleri added a commit that referenced this issue Jan 27, 2025
@LincolnPuzey @pierrecamilleri
Vendor stringcase library (#1727)
12db3c2 
- fixes #1655 

Commits:
- Vendor `stringcase` library
- Fix deprecation warning in it
- Swap so it is used, remove dependency on actual library

---------

Co-authored-by: Pierre Camilleri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Vendor stringcase library LincolnPuzey/frictionless-py
2 participants
@LincolnPuzey @pierrecamilleri