#1728: add pass_row as configurable parameter for field_update #1729
+36
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld_update # Description As described in frictionlessdata#1728, pass_row parameter is now added as an editable parameter for the field_update step. This allows us to use row data inside custom python function. # Tests Ensured the newly added unit test ` test_step_field_update_with_function_and_pass_row_true` runs without fail and also that all the previous test cases run and pass too.
|
Thanks for the PR ! I'll try to have a look at it soon. |
Co-authored-by: Pierre Camilleri <[email protected]>
pierrecamilleri
approved these changes
Jan 27, 2025
|
Thanks a lot for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in #1728, pass_row parameter is now added as an editable parameter for the field_update step. This allows us to use row data inside custom python function.
The default value of the parameter remains False so that any existing uses of this functionality will not be affected.
Tests
Ensured the newly added unit test
test_step_field_update_with_function_and_pass_row_trueruns without fail and also that all the previous test cases run and pass too.