Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can KeyValues.fromelem be made into a @classmethod? #8

Open
goodboy opened this issue Sep 25, 2017 · 0 comments
Open

Can KeyValues.fromelem be made into a @classmethod? #8

goodboy opened this issue Sep 25, 2017 · 0 comments

Comments

@goodboy
Copy link
Member

goodboy commented Sep 25, 2017

Issue by tgoodlet
Friday Sep 23, 2016 at 21:04 GMT
Originally opened as sangoma/sandswitches#4


KeyValues.fromelem() currently creates a new instance of the same type but with additional instance state (as defined in kwargs) passed on and assigned to the new object.

The question is whether this can be changed to a classmethod which seems much more fitting. The question of the state passing is what needs to be addressed and I have a feeling that progress with #2 may aid with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant