Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors should be written to stderr not stdout #611

Open
barrett-ruth opened this issue Sep 13, 2023 · 11 comments
Open

Errors should be written to stderr not stdout #611

barrett-ruth opened this issue Sep 13, 2023 · 11 comments
Labels
bug Something isn't working

Comments

@barrett-ruth
Copy link

Write errors to stdout. prettier does the same.

image
@fsouza
Copy link
Owner

fsouza commented Sep 22, 2023

It looks like core_d doesn't support this currently (see mantoni/core_d.js#19). It makes sense though. I'll try to find some time to send a PR to core_d.

@barrett-ruth
Copy link
Author

@fsouza is there a reason this behavior is still occuring?
image

Do I need a new release of prettierd?

@fsouza
Copy link
Owner

fsouza commented Oct 20, 2023

Do I need a new release of prettierd?

Hmm interesting, that release should include the updated core_d, I wonder where the issue is. I'll check what's up.

@jeffshaver
Copy link

@fsouza have you figured out whats going on here? is there anything anyone can help with?

@fsouza
Copy link
Owner

fsouza commented Nov 8, 2023

I haven't had a chance to look into it yet. My plan was to try to repro and trace down whether some errors are being written via the wrong function in core_d or something like that.

@fsouza
Copy link
Owner

fsouza commented Nov 10, 2023

I just took a look into this, it's actually a bit trickier to fix, as with core_d you only know whether something failed or not at the end of the stream. We'd need to support the concept of stream when reading data from the socket. I started an issue in core_d where we can discuss it: mantoni/core_d.js#28

@jeffshaver
Copy link

@fsouza in the linked core_d issue (mantoni/core_d.js#28), the maintainer replied. does the stuff in 6.1.0 solve the issue and prettierd just needs to upgrade core_d again?

@fsouza
Copy link
Owner

fsouza commented Dec 5, 2023

@jeffshaver that will help debugging, but won't stop errors from being sent to the editor. I'll push a new release of prettierd with that feature though.

@powerman
Copy link

powerman commented Jul 3, 2024

0.25.3 - it's still actual. 😞

And one more issue: it's impossible to switch off colors. This breaks other things: stevearc/conform.nvim#486
изображение

@barrett-ruth
Copy link
Author

Let's see if we can get this resolved. Is there any way I can help @fsouza ?

@igor-ribeiro
Copy link

Any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants