Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Paket.Core to support .NET 8.0 #2776

Merged
merged 2 commits into from
Jul 14, 2024

Conversation

Thorium
Copy link
Member

@Thorium Thorium commented May 26, 2024

Description

Updated Paket reference.

@xperiandri
Copy link
Collaborator

Do we need to mention this in the release notes? I suppose it does not affect anyone except maintainers and contributors

@Thorium
Copy link
Member Author

Thorium commented Jul 11, 2024

This does affect if you run Paket restore via Fake. But I'd bundle with it under general .NET8 compatibility updates.

The issue is that Paket parses Nuget dependencies to paket.lock file and sometimes different frameworks have different dependencies. So if you are so unfortunate that you have a sub-dependency to a package which says "my dependencies in net8.0 are..." then the Paket v6 raises that "there is no such framework as net8", and the restore fails, even if you didn't actually use net8 yourself.

Edit: To be clear, this PR fixes that issue.

(The main reason I don't want to update readme is that it just creates more merge-conflicts.)

@xperiandri
Copy link
Collaborator

@Numpsy what do you think?

@Numpsy
Copy link
Contributor

Numpsy commented Jul 12, 2024

There are quite a few Could not detect any platforms from 'net8.0' in %package% warnings in the CI builds and it'd be nice to get that fixed, but i'm not using Paket myself so I don't know if there are any other ramifications of changing it

@Numpsy
Copy link
Contributor

Numpsy commented Jul 12, 2024

I see that Paket 8 also added support for .NET Framework 4.8.1, so maybe this change would be helpful to anyone using that as well?

@xperiandri xperiandri merged commit edf7a5e into fsprojects:master Jul 14, 2024
3 checks passed
@NogginBops
Copy link

This is blocking us from upgrading to .net8.0.
Would it be possible to release a prerelease version of FAKE with these fixes as a temporary measure?

@xperiandri
Copy link
Collaborator

Let me get back home next Monday and I will figure out how to release

@NogginBops
Copy link

@xperiandri Just a reminder about this, just in case. 🙂

@NogginBops
Copy link

@xperiandri if there is anything I can help with that could speed up the release of the pre-release package I would be willing to give it a try. Also should I open a separate issue for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants