Don't put a space before a prefix operator, unless we have to. #3134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
brianrourkeboll
approved these changes
Oct 29, 2024
| "86u" | ||
| "86ul" | ||
| "0x00002D3Fun" | ||
| "86UL" |
There was a problem hiding this comment.
Suggested change
| "86UL" | |
| "86UL" | |
| "1<m> |
Or in a separate test if you like.
dawedawe
approved these changes
Oct 31, 2024
Merged
nojaf
added a commit
that referenced
this pull request
Jan 10, 2025
* Don't put a space before a prefix operator, unless we have to. * Add feedback from code review * Only add space to measure when constant has sign. * Remove unnecessary open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3131
Could you review this one for me @brianrourkeboll? Just to make sure I didn't miss anything.
@dawedawe please review the Fantomas' side of things.
Thanks all!