Revert removing the mode from open()

Author: hugovk

fsspec/implementations/cache_metadata.py

@@ -55,7 +55,7 @@ def __init__(self, storage: list[str]):
     def _load(self, fn: str) -> Detail:
         """Low-level function to load metadata from specific file"""
         try:
-            with open(fn) as f:
+            with open(fn, "r") as f:
                 loaded = json.load(f)
         except ValueError:
             with open(fn, "rb") as f:

fsspec/implementations/tests/test_cached.py

@@ -185,7 +185,7 @@ def test_metadata_replace_pickle_with_json(tmpdir):
         assert f.read(5) == b"test"
 
     # Confirm metadata is in json format
-    with open(cache_fn) as f:
+    with open(cache_fn, "r") as f:
         metadata = json.load(f)
     assert list(metadata.keys()) == [make_path_posix(afile)]
 
@@ -253,7 +253,7 @@ def test_blockcache_workflow(ftp_writable, tmp_path, force_save_pickle):
         with open(tmp_path / "cache", "rb") as f:
             cache = pickle.load(f)
     else:
-        with open(tmp_path / "cache") as f:
+        with open(tmp_path / "cache", "r") as f:
             cache = json.load(f)
     assert "/out" in cache
     assert cache["/out"]["blocks"] == [0, 1]
@@ -370,7 +370,7 @@ def __ager(cache_fn, fn, del_fn=False):
                 with open(cache_fn, "rb") as f:
                     cached_files = pickle.load(f)
             else:
-                with open(cache_fn) as f:
+                with open(cache_fn, "r") as f:
                     cached_files = json.load(f)
             fn_posix = pathlib.Path(fn).as_posix()
             cached_files[fn_posix]["time"] = cached_files[fn_posix]["time"] - 691200

fsspec/implementations/tests/test_git.py

@@ -24,7 +24,7 @@ def repo():
         open(os.path.join(d, "file1"), "wb").write(b"data0")
         subprocess.call("git add file1", shell=True, cwd=d)
         subprocess.call('git commit -m "init"', shell=True, cwd=d)
-        sha = open(os.path.join(d, ".git/refs/heads/master")).read().strip()
+        sha = open(os.path.join(d, ".git/refs/heads/master"), "r").read().strip()
         open(os.path.join(d, "file1"), "wb").write(b"data00")
         subprocess.check_output('git commit -a -m "tagger"', shell=True, cwd=d)
         subprocess.call('git tag -a thetag -m "make tag"', shell=True, cwd=d)

fsspec/tests/test_core.py

@@ -304,14 +304,14 @@ def test_open_file_write_with_special_characters(tmp_path, char, monkeypatch):
     with fsspec.open(file_path, "w", expand=False) as f:
         f.write(expected_content)
 
-    with open(file_path) as f:
+    with open(file_path, "r") as f:
         actual_content = f.read()
 
     monkeypatch.setattr(fsspec.core, "DEFAULT_EXPAND", False)
     with fsspec.open(file_path, "w") as f:
         f.write(expected_content * 2)
 
-    with open(file_path) as f:
+    with open(file_path, "r") as f:
         assert f.read() == actual_content * 2
 
     assert actual_content == expected_content
@@ -347,7 +347,7 @@ def test_open_files_write_with_special_characters(tmp_path, char):
     )[0] as f:
         f.write(expected_content)
 
-    with open(file_path) as f:
+    with open(file_path, "r") as f:
         actual_content = f.read()
 
     assert actual_content == expected_content

fsspec/tests/test_fuse.py

@@ -139,7 +139,7 @@ def test_seek_rw(mount_local):
     fh.write("st")
     fh.close()
 
-    fh = open(mount_dir / "text")
+    fh = open(mount_dir / "text", "r")
     assert fh.read() == "test"
     fh.seek(2)
     assert fh.read() == "st"