Unquote Username and Password

[geoffjukes]

Apologies for brevity, I’m on my cell.

I have a bunch or URLs that contain usernames and passwords. All “special” characters have been URL Encoded (“quoted”, to use urllib’s term). But when using url_to_fs, any URL’s with encoded characters fail.

I think there’s a simple fix. If you wrap these two in urllib’s “unquote”.

filesystem_spec/fsspec/utils.py

Line 108 in 8463a6a

options["username"] = parsed_path.username

filesystem_spec/fsspec/utils.py

Line 108 in 8463a6a

options["username"] = parsed_path.username

If that’s not possible, I’ll implement a simplified equivalent of url_to_fs. Just figured I’d ask first :)

[martindurant]

Would you mind showing an example of how such a URL looks?
You may be totally right that unquote is warranted for the username.

[martindurant]

Was there a specific associated change to go with this? I do think that we might need to be careful, and only apply to the HTTP backend or maybe others that are explicitly tied to real URLs, because something like SSH would not expect to have encoded strings.