Skip to content

_ls overrides base class in incompatible manner #945

@kylebarron

Description

@kylebarron

Here you default to detail=False in _ls

s3fs/s3fs/core.py

Line 1021 in b4d3fa8

async def _ls(self, path, detail=False, refresh=False, versions=False):

but in the base class of AsyncFileSystem you default to detail=True.

Is it intentional to override the base class in this way? Is every implementor intended to disregard the default value of detail in the base class?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions