Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No retries on ConnectTimeoutError #951

Open
arogozhnikov opened this issue Mar 17, 2025 · 0 comments
Open

No retries on ConnectTimeoutError #951

arogozhnikov opened this issue Mar 17, 2025 · 0 comments

Comments

@arogozhnikov
Copy link
Contributor

I'm observing ConnectTimeoutError sometimes, which is likely caused by the network and searching for a right way to handle thimeouts.

I see s3fs has retries with exponential backoff, but it ignores

How this can be tested/reproduced:

sudo apt install iproute2    # likely you already have it
sudo tc qdisc add dev eth0 root netem delay 3500ms    # set delay on network
# sudo tc qdisc del dev eth0 root     # use to remove delay when done with testing.

now in python:

import s3fs
s3fs.S3FileSystem().exists('s3://example-bucker/example-folder')

This crashes with

ConnectTimeoutError: Connect timeout on endpoint URL: "https://example-bucker.s3.us-west-2.amazonaws.com/example-folder"

This failure is expected, BUT when I insert logging in s3fs, it does not retry this exception (though default retries=5). Should this exception be retried?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant