Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetMateInformation should add the MQ tag to any supplementary alignments #960

Open
msto opened this issue Jan 26, 2024 · 1 comment
Open

Comments

@msto
Copy link
Contributor

msto commented Jan 26, 2024

Currently, SetMateInformation does not add the MQ tag to supplementary alignments.

I'm not sure if this is intended behavior - the docs suggest that supplementary alignments would have this tag added.

Adds and/or fixes mate information on paired-end reads. Sets the MQ (mate mapping quality), 'MC' (mate cigar string),
ensures all mate-related flag fields are set correctly, and that the mate reference and mate start position are
correct.

Supplementary records are handled correctly (updated with their mate's non-supplemental attributes). Secondary
alignments are passed through but are not updated.

GroupReadsByUmi requires that all alignments, including supplementary alignments, have the MQ tag set, so it would be helpful if SetMateInformation produced a compatible BAM 🙂

@nh13
Copy link
Member

nh13 commented Jan 26, 2024

We use the SetMateInfoIterator from htsjdk which routes to the setMateInformationOnSupplementalAlignment method

It looks like MQ is not set on the supplementary records, so we'd likely need to make a PR into htsjdk, wait for a release, then update fgbio's htsjdk dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants