Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SvPileup should ignore reads marked as duplicates #41

Open
ameynert opened this issue Jul 15, 2024 · 3 comments
Open

SvPileup should ignore reads marked as duplicates #41

ameynert opened this issue Jul 15, 2024 · 3 comments

Comments

@ameynert
Copy link

The number of pileups changes when duplicate reads are removed.

Test examples went from 575 > 283 pileups and 2030 > 550 pileups.

@nh13
Copy link
Member

nh13 commented Jul 15, 2024

I would add an option to the tool to ignore duplicates, with default false for backwards compatibility.

@tfenne
Copy link
Member

tfenne commented Jul 15, 2024

I'm going to disagree slightly and suggest that we add:
val includeDuplicates: Boolean = False
and bump the major version number. Seems like a big footgun to leave in place unless we think there's a good reason the majority of use cases would call for also looking at the duplicates?

@nh13
Copy link
Member

nh13 commented Jul 15, 2024

Major bump would fine by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants