Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper command-line usage for fqgrep #32

Closed
kockan opened this issue Aug 18, 2023 · 3 comments · Fixed by #46
Closed

Proper command-line usage for fqgrep #32

kockan opened this issue Aug 18, 2023 · 3 comments · Fixed by #46

Comments

@kockan
Copy link

kockan commented Aug 18, 2023

The current README displays usage as:

fqgrep -r 'GACGAGATTA' -a 'GACGTGATTA' --r1-fastq /data/testR1.fastq.gz --r2-fastq /data/testR2.fastq.gz -o ./test_out -t 28

However, the way I'm currently testing the program looks like:

fqgrep --progress --threads 8 --color always <my_pattern> test.fastq test.fastq.gz test.fastq.zst

as the former command does not work and the latter seems to be in-line with the output of fqgrep -h , which is:

fqgrep [FLAGS] [OPTIONS] [--] [args]...

Which one of these is the long-term planned proper command-line usage? Happy to do a PR on the README if it should actually be changed, just wanted to confirm.

@nh13
Copy link
Member

nh13 commented Aug 18, 2023

@kockan the intention is to have the command line options to match grep as much as possible, with no conflicts with bioinformatics-specific options (e.g. --reverse-complement). So the usage is very much out of date and the way you're testing it is the correct way. We'd welcome a PR!

And I am glad someone is using this other than ourselves!

@kockan
Copy link
Author

kockan commented Aug 21, 2023

#33

@msto
Copy link
Contributor

msto commented Mar 7, 2025

@nh13 bumping this issue, I also noticed when opening #43 that the available CLI options don't match the usage described in the repo's README.

@nh13 nh13 linked a pull request Mar 7, 2025 that will close this issue
@nh13 nh13 closed this as completed in #46 Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants