Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing method of cutting wedge #230

Open
shimwell opened this issue Mar 31, 2022 · 0 comments
Open

changing method of cutting wedge #230

shimwell opened this issue Mar 31, 2022 · 0 comments

Comments

@shimwell
Copy link
Member

Currently a cutting wedge is used in the following way

cutting_wedge = calculate_wedge_cut(self)
solid = self.perform_boolean_operations(solid, wedge_cut=cutting_wedge)

which doesn't work well for extruded shapes or shapes without a radius and height attribute.

We could use this approach instead

largest_dim = get_largest_dimension(solid)
cutting_wedge = CuttingWedge(height=largest_dim*2, radius=largest_dim*2, rotation_angle=360.-self.rotation_angle)

Perhaps as a first stage tests for the volume of all parametric components should be added to a new unit test file. this file would have shapes with 360 rotation and 90 degree rotation and check the volume is 1/4

this will be easier one #229 is complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant