New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max values should also consider the abs of the x and y, z values #343

Open

shimwell opened this issue Oct 9, 2024 · 0 comments

Member

shimwell commented Oct 9, 2024

These lines attempt to find the size of bounding box but they should also consider the abs() value

paramak/src/paramak/workplanes/toroidal_field_coil_princeton_d.py

Lines 208 to 209 in e7fe4b3

    
           radius = max(bb.xmax, bb.ymax)*2.1 # larger than the bounding box to ensure clean cut 
        
           height = max(bb.zmax, bb.zmin)*2.1 # larger than the bounding box to ensure clean cut

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment