Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tokamak_from_plasma using vertical build based on outboard radial build causes clashes #351

Open
tokasamwin opened this issue Oct 14, 2024 · 1 comment

Comments

@tokasamwin
Copy link
Contributor

tokasamwin commented Oct 14, 2024

Before

The approach used to generate the vertical build from the radial build causes clashes on the inboard side if the outboard build is larger than the inboard.

The cause is that the vertical build is based on the outboard radial build, as the inboard shapes go from the inboard build at inboard radius, equatorial to outboard build at vertical, often increasing in thickness along the inboard side. Switching this to the inboard radial build prevents this issue, and is also more appropriate to blanket thicknesses/space allocation, as both inboard and upper/lower regions have lower flux than the outboard build.

After

@shimwell
Copy link
Member

shimwell commented Oct 14, 2024

Many thanks for spotting this and reporting and making a PR. Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants