Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ideas for improvements #4

Open
michaelzangerle opened this issue Aug 16, 2018 · 0 comments
Open

Ideas for improvements #4

michaelzangerle opened this issue Aug 16, 2018 · 0 comments

Comments

@michaelzangerle
Copy link
Member

@tarekis and I recently discussed some of the different cases which could occur when using this bundle and agreed on two things:

A
To show the user a reasonable / helpful error it would probably be a good idea to include the time a user is blocked in the event.

B
Consider the following scenario: A user hits the rate limit and is blocker for e.g. an hour. At the moment the time he is blocked will be reset every time he tries again. This could be the right thing but on the other hand we should also consider users that just wanted to know if it's working now. I think it probably depends mostly on the type of project and how much security related pressure is on the site. So how about making it configurable whether the period of time a user is blocked for should be increased or be left unchanged.

@atroy What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant