Skip to content

Commit 7ba474a

Browse files
authored
Fixed an error when disposing (#391)
1 parent 0a74c3f commit 7ba474a

File tree

5 files changed

+8
-4
lines changed

5 files changed

+8
-4
lines changed

packages/cheetah-grid/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "cheetah-grid",
3-
"version": "1.8.5",
3+
"version": "1.8.6",
44
"description": "Cheetah Grid is a high performance grid engine that works on canvas",
55
"keywords": [
66
"spreadsheet",

packages/cheetah-grid/src/js/columns/action/internal/InlineMenuElement.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,6 @@ export class InlineMenuElement<T> {
225225
delete this._menu;
226226
this._beforePropEditor = null;
227227
menu.parentElement?.removeChild(menu);
228-
this._deregisterBodyClickListener();
229228
}
230229
attach(
231230
grid: ListGridAPI<T>,

packages/cheetah-grid/src/test/ListGrid_sample.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ <h1>ListGrid Example</h1>
3232
<button id="filter">filter</button>
3333
<button id="unfilter">unfilter</button>
3434
<button id="focus">focus</button>
35+
<button id="dispose">dispose</button>
3536
<div id="parent" style="width: 100%;height: calc(100% - 62px);">
3637
</div>
3738
<script type="text/javascript" src="./ListGrid_sample.js"></script>

packages/cheetah-grid/src/test/ListGrid_sample.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,6 @@ Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deseru
262262
};
263263
// filter
264264

265-
266265
/////// jump
267266
const focusButton = document.querySelector('#focus');
268267
focusButton.onclick = function() {
@@ -271,6 +270,11 @@ Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deseru
271270
};
272271
/////// jump
273272

273+
const disposeButton = document.querySelector('#dispose');
274+
disposeButton.onclick = function() {
275+
grid.dispose();
276+
};
277+
274278
cheetahGrid.register.theme('RED', cheetahGrid.themes.default.extends({
275279
color: 'red',
276280
defaultBgColor: '#FDD',

packages/vue-cheetah-grid/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "vue-cheetah-grid",
3-
"version": "1.8.5",
3+
"version": "1.8.6",
44
"description": "Cheetah Grid for Vue.js",
55
"main": "lib/index.js",
66
"unpkg": "dist/vueCheetahGrid.js",

0 commit comments

Comments
 (0)