Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
CRITICAL FIX: Not all differentials can cause Diff test failures
This is reported bug #199: rurban/smhasher#199 To see this bug in action, apply the following patch (without this fix!): @@ -158,7 +158,7 @@ bool DiffTest ( pfHash hash, int diffbits, int reps, bool dumpCollisions ) reps,testcount,expected); Hash_Seed_init (hash, g_seed); - for(int i = 0; i < reps; i++) + for(int i = 0; i < 0; i++) { if(i % (reps/10) == 0) printf("."); @@ -173,6 +173,10 @@ bool DiffTest ( pfHash hash, int diffbits, int reps, bool dumpCollisions ) bool result = true; + r.rand_p(&k1,sizeof(keytype)); + diffs.push_back(k1); + diffs.push_back(k1); + result &= ProcessDifferentials(diffs,reps,dumpCollisions); return result;
- Loading branch information