Skip to content

Commit 0448113

Browse files
authored
Fix Shimmers isLoading Error Section (#435)
* Shimmers isLoading Error Section * removed console log
1 parent e0dbb1a commit 0448113

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

src/app/shared/components/dashboard/dashboard-error-section/dashboard-error-section.component.ts

+1
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,7 @@ export class DashboardErrorSectionComponent implements OnInit {
125125
}
126126

127127
showMappingResolve(errorType: AccountingErrorType, groupedError: Error[], sourceField: ExportErrorSourceType) {
128+
this.isLoading = true;
128129
this.eventStartTime = new Date();
129130
this.errorType = errorType;
130131
this.groupedError = groupedError;

src/app/shared/components/helper/mapping/generic-mapping-table/generic-mapping-table.component.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@
77
</tr>
88
</ng-template>
99
<ng-template pTemplate="body" let-mapping>
10-
<tr>
10+
<tr *ngIf="!isLoading">
1111
<td>
1212
<div class="tw-flex tw-items-center">
13-
<svg-icon-sprite *ngIf="mapping.auto_mapped" pTooltip="Auto-mapped" tooltipPosition="top" src="flash" width="12px" height="12px" class="tw-mr-12-px tw-text-placeholder"></svg-icon-sprite>
13+
<svg-icon-sprite *ngIf="mapping.auto_mapped && !isDashboardMappingResolve" pTooltip="Auto-mapped" tooltipPosition="top" src="flash" width="12px" height="12px" class="tw-mr-12-px tw-text-placeholder"></svg-icon-sprite>
1414
<span [ngClass]="{'tw-pl-24-px': !mapping.auto_mapped}">{{ mapping.value }}</span>
1515
</div>
1616
</td>

src/app/shared/components/helper/shimmers/shimmers.component.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
<!-- Mapping Resolve Table Shimmers -->
2828
<div *ngIf="isMappingTableShimmers">
2929
<tr *ngFor="let _ of [0,1,2,3,4,5,6]">
30-
<td *ngIf="isMappingTableShimmers"><p-skeleton width="150px" height="28px" shape="rectangle"></p-skeleton></td>
31-
<td *ngIf="isMappingTableShimmers"><p-skeleton width="250px" height="28px" shape="rectangle"></p-skeleton></td>
30+
<td><p-skeleton width="150px" height="28px" shape="rectangle"></p-skeleton></td>
31+
<td><p-skeleton width="250px" height="28px" shape="rectangle"></p-skeleton></td>
3232
</tr>
3333
</div>

0 commit comments

Comments
 (0)