Skip to content

Commit 57fb635

Browse files
committed
fix: form value bug fixes (#1022)
1 parent d1f26ef commit 57fb635

File tree

18 files changed

+73
-22
lines changed

18 files changed

+73
-22
lines changed

src/app/core/models/common/advanced-settings.model.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ export class SkipExportModel {
189189

190190
static setConditionFields(response: ExpenseFilterResponse, conditionArray: ConditionField[], conditionFieldOptions: ConditionField[]) {
191191
response.results.forEach((element) => {
192-
const type = conditionFieldOptions?.filter( (fieldOption) => fieldOption.field_name === element.condition);
192+
const type = conditionFieldOptions?.filter( (fieldOption) => fieldOption.field_name.toLowerCase() === element.condition.toLowerCase());
193193
const selectedConditionOption : ConditionField = type[0];
194194
conditionArray.push(selectedConditionOption);
195195
});

src/app/integrations/business-central/business-central-shared/business-central-advanced-settings/business-central-advanced-settings.component.html

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,15 +86,16 @@ <h4 class="tw-text-form-label-text-color tw-mb-12-px">Preview of the Description
8686
[skipExportForm]="skipExportForm"
8787
[expenseFilter]="expenseFilters"
8888
[conditionFieldOptions]="conditionFieldOptions"
89-
(deleteSkipExportForm)="deleteExpenseFilter($event)">
89+
(deleteSkipExportForm)="deleteExpenseFilter($event)"
90+
(invalidSkipExportForm)="invalidSkipExportForm($event)">
9091
</app-configuration-skip-export>
9192
</div>
9293
</div>
9394
</div>
9495
<app-configuration-step-footer
9596
[ctaText] = "!isSaveInProgress ? (isOnboarding ? ConfigurationCtaText.SAVE_AND_CONTINUE : ConfigurationCtaText.SAVE) : ConfigurationCtaText.SAVING"
9697
[showBackButton] = "isOnboarding"
97-
[isButtonDisabled]="!advancedSettingForm.valid || !skipExportForm.valid || !getSkipExportValue()"
98+
[isButtonDisabled]="!advancedSettingForm.valid || !skipExportForm.valid || !getSkipExportValue() || isSkipExportFormInvalid"
9899
(save)="save()"
99100
(navigateToPreviousStep)="navigateBack()">
100101
</app-configuration-step-footer>

src/app/integrations/business-central/business-central-shared/business-central-advanced-settings/business-central-advanced-settings.component.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,8 @@ export class BusinessCentralAdvancedSettingsComponent implements OnInit {
5959

6060
readonly brandingConfig = brandingConfig;
6161

62+
isSkipExportFormInvalid: boolean;
63+
6264
constructor(
6365
private advancedSettingsService: BusinessCentralAdvancedSettingsService,
6466
private helper: HelperService,
@@ -70,6 +72,10 @@ export class BusinessCentralAdvancedSettingsComponent implements OnInit {
7072
private router: Router
7173
) { }
7274

75+
invalidSkipExportForm($event: boolean) {
76+
this.isSkipExportFormInvalid = $event;
77+
}
78+
7379
getSkipExportValue() {
7480
if (this.advancedSettingForm.controls.skipExport) {
7581
if (this.skipExportForm.controls.condition1.value) {

src/app/integrations/intacct/intacct-shared/intacct-advanced-settings/intacct-advanced-settings.component.html

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,8 @@
133133
#skipExportChild
134134
[enableSkipExport]="advancedSettingsForm.get('skipSelectiveExpenses')?.value"
135135
[skipExportForm]="skipExportForm"
136-
(skipExportFormChange)="updateForm($event)">
136+
(skipExportFormChange)="updateForm($event)"
137+
(invalidSkipExportForm)="invalidSkipExportForm($event)">
137138
</app-skip-export>
138139
</div>
139140
</div>
@@ -238,6 +239,6 @@
238239
</div>
239240
</div>
240241
</div>
241-
<app-configuration-step-footer (navigateToPreviousStep)="navigateToPreviousStep()" [ctaText] = "!saveInProgress ? (isOnboarding ? ConfigurationCtaText.SAVE_AND_CONTINUE : ConfigurationCtaText.SAVE) : ConfigurationCtaText.SAVING" (save)="save()" [isButtonDisabled]="!advancedSettingsForm.valid || (advancedSettingsForm.get('skipSelectiveExpenses')?.value ? !skipExportForm.valid : false)" [showBackButton]="isOnboarding ? true : false"></app-configuration-step-footer>
242+
<app-configuration-step-footer (navigateToPreviousStep)="navigateToPreviousStep()" [ctaText] = "!saveInProgress ? (isOnboarding ? ConfigurationCtaText.SAVE_AND_CONTINUE : ConfigurationCtaText.SAVE) : ConfigurationCtaText.SAVING" (save)="save()" [isButtonDisabled]="isSkipExportFormInvalid || !advancedSettingsForm.valid || (advancedSettingsForm.get('skipSelectiveExpenses')?.value ? !skipExportForm.valid : false)" [showBackButton]="isOnboarding ? true : false"></app-configuration-step-footer>
242243
</form>
243244
</div>

src/app/integrations/intacct/intacct-shared/intacct-advanced-settings/intacct-advanced-settings.component.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ import { DestinationAttribute } from 'src/app/core/models/db/destination-attribu
2828
})
2929

3030
export class IntacctAdvancedSettingsComponent implements OnInit {
31+
isSkipExportFormInvalid: boolean;
3132

3233
@ViewChild('skipExportChild') skipExportChild: SkipExportComponent;
3334

@@ -129,6 +130,10 @@ export class IntacctAdvancedSettingsComponent implements OnInit {
129130
private mappingService: SiMappingsService
130131
) { }
131132

133+
invalidSkipExportForm($event: boolean) {
134+
this.isSkipExportFormInvalid = $event;
135+
}
136+
132137
navigateToPreviousStep(): void {
133138
this.router.navigate([`/integrations/intacct/onboarding/import_settings`]);
134139
}

src/app/integrations/intacct/intacct-shared/intacct-c1-import-settings/intacct-c1-import-settings.component.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,9 @@ export class IntacctC1ImportSettingsComponent implements OnInit {
192192
}
193193

194194
closeModel() {
195+
this.customFieldControl.patchValue({
196+
source_field: null
197+
});
195198
this.customFieldForm.reset();
196199
this.showDialog = false;
197200
}

src/app/integrations/intacct/intacct-shared/intacct-import-settings/intacct-import-settings.component.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,6 +258,9 @@ export class IntacctImportSettingsComponent implements OnInit {
258258
}
259259

260260
closeModel() {
261+
this.customFieldControl.patchValue({
262+
source_field: null
263+
});
261264
this.customFieldForm.reset();
262265
this.showDialog = false;
263266
}
@@ -343,7 +346,7 @@ export class IntacctImportSettingsComponent implements OnInit {
343346
this.importSettingsForm.controls.costTypes.setValidators(Validators.required);
344347
} else {
345348
this.importSettingsForm.controls.costCodes.disable();
346-
this.importSettingsForm.controls.costTypes.disable();
349+
this.importSettingsForm.controls.costTypes.disable();
347350
this.importSettingsForm.controls.costCodes.clearValidators();
348351
this.importSettingsForm.controls.costTypes.clearValidators();
349352
}

src/app/integrations/netsuite/netsuite-shared/netsuite-advanced-settings/netsuite-advanced-settings.component.html

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,8 @@ <h4 class="tw-text-form-label-text-color tw-mb-12-px">{{brandingContent.previewD
149149
[skipExportForm]="skipExportForm"
150150
[expenseFilter]="expenseFilters"
151151
[conditionFieldOptions]="conditionFieldOptions"
152-
(deleteSkipExportForm)="deleteExpenseFilter($event)">
152+
(deleteSkipExportForm)="deleteExpenseFilter($event)"
153+
(invalidSkipExportForm)="invalidSkipExportForm($event)">
153154
</app-configuration-skip-export>
154155
</div>
155156
</div>
@@ -246,7 +247,7 @@ <h4 class="tw-text-form-label-text-color tw-mb-12-px">{{brandingContent.previewD
246247
</div>
247248
<app-configuration-step-footer
248249
[ctaText] = "!isSaveInProgress ? (isOnboarding ? ConfigurationCtaText.SAVE_AND_CONTINUE : ConfigurationCtaText.SAVE) : ConfigurationCtaText.SAVING"
249-
[isButtonDisabled]="!advancedSettingForm.valid"
250+
[isButtonDisabled]="!advancedSettingForm.valid || isSkipExportFormInvalid"
250251
[showBackButton]="isOnboarding ? true : false"
251252
(save)="save()"
252253
(navigateToPreviousStep)="navigateToPreviousStep()">

src/app/integrations/netsuite/netsuite-shared/netsuite-advanced-settings/netsuite-advanced-settings.component.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,8 @@ export class NetsuiteAdvancedSettingsComponent implements OnInit {
9191

9292
readonly brandingContent = brandingContent.netsuite.configuration.advancedSettings;
9393

94+
isSkipExportFormInvalid: boolean;
95+
9496
constructor(
9597
private advancedSettingsService: NetsuiteAdvancedSettingsService,
9698
private configurationService: ConfigurationService,
@@ -107,6 +109,10 @@ export class NetsuiteAdvancedSettingsComponent implements OnInit {
107109
return brandingConfig.brandId === 'co' ? ' \(optional\)' : '';
108110
}
109111

112+
invalidSkipExportForm($event: boolean) {
113+
this.isSkipExportFormInvalid = $event;
114+
}
115+
110116
getCreateVendorLabel(): string {
111117
if (this.workspaceGeneralSettings.employee_field_mapping === EmployeeFieldMapping.VENDOR) {
112118
return brandingConfig.brandId === 'co' ? EmployeeFieldMapping.VENDOR.toLowerCase() : new TitleCasePipe().transform(EmployeeFieldMapping.VENDOR);

src/app/integrations/qbo/qbo-shared/qbo-advanced-settings/qbo-advanced-settings.component.html

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,14 +152,15 @@ <h4 class="tw-text-form-label-text-color tw-mb-12-px">{{brandingContent.previewD
152152
[skipExportForm]="skipExportForm"
153153
[expenseFilter]="expenseFilters"
154154
[conditionFieldOptions]="conditionFieldOptions"
155-
(deleteSkipExportForm)="deleteExpenseFilter($event)">
155+
(deleteSkipExportForm)="deleteExpenseFilter($event)"
156+
(invalidSkipExportForm)="invalidSkipExportForm($event)">
156157
</app-configuration-skip-export>
157158
</div>
158159
</div>
159160
</div>
160161
<app-configuration-step-footer
161162
[ctaText] = "!isSaveInProgress ? (isOnboarding ? ConfigurationCtaText.SAVE_AND_CONTINUE : ConfigurationCtaText.SAVE) : ConfigurationCtaText.SAVING"
162-
[isButtonDisabled]="!advancedSettingForm.valid"
163+
[isButtonDisabled]="!advancedSettingForm.valid || isSkipExportFormInvalid"
163164
[showBackButton]="isOnboarding ? true : false"
164165
(save)="save()"
165166
(navigateToPreviousStep)="navigateToPreviousStep()"></app-configuration-step-footer>

0 commit comments

Comments
 (0)