Skip to content

Commit 5a88f06

Browse files
authored
Skip Export Log: Date Filter Fix (#450)
* Skip Export Log: Date Filter Fix * pr comments
1 parent f97c6b3 commit 5a88f06

File tree

5 files changed

+26
-7
lines changed

5 files changed

+26
-7
lines changed

src/app/core/models/db/expense-group.model.ts

+8
Original file line numberDiff line numberDiff line change
@@ -34,3 +34,11 @@ export type ExpenseGroupParam = {
3434
exported_at__gte?: string;
3535
exported_at__lte?: string;
3636
}
37+
38+
export type SkipExportParam = {
39+
limit: number;
40+
offset: number;
41+
org_id: string;
42+
start_date?: string;
43+
end_date?: string;
44+
}

src/app/core/services/common/export-log.service.ts

+15-4
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { FyleReferenceType, TaskLogState } from '../../models/enum/enum.model';
88
import { Observable } from 'rxjs';
99
import { AccountingExport } from '../../models/db/accounting-export.model';
1010
import { SelectedDateFilter } from '../../models/qbd/misc/date-filter.model';
11-
import { ExpenseGroupParam, ExpenseGroupResponse } from '../../models/db/expense-group.model';
11+
import { ExpenseGroupParam, ExpenseGroupResponse, SkipExportParam } from '../../models/db/expense-group.model';
1212

1313
@Injectable({
1414
providedIn: 'root'
@@ -23,11 +23,22 @@ export class ExportLogService {
2323
private workspaceService: WorkspaceService
2424
) { }
2525

26-
getSkippedExpenses(limit: number, offset: number): Observable<SkipExportLogResponse> {
26+
getSkippedExpenses(limit: number, offset: number, selectedDateFilter: SelectedDateFilter | null): Observable<SkipExportLogResponse> {
2727
const workspaceId = this.workspaceService.getWorkspaceId();
28-
const org_id = this.userService.getUserProfile().org_id;
28+
const params: SkipExportParam = {
29+
limit,
30+
offset,
31+
org_id: this.userService.getUserProfile().org_id
32+
};
33+
params.org_id = this.userService.getUserProfile().org_id;;
2934

30-
return this.apiService.get(`/workspaces/${workspaceId}/fyle/expenses/`, {limit, offset, org_id: org_id, is_skipped: true});
35+
if (selectedDateFilter) {
36+
const startDate = selectedDateFilter.startDate.toLocaleDateString().split('/');
37+
const endDate = selectedDateFilter.endDate.toLocaleDateString().split('/');
38+
params.start_date = `${startDate[2]}-${startDate[1]}-${startDate[0]}T00:00:00`;
39+
params.end_date = `${endDate[2]}-${endDate[1]}-${endDate[0]}T23:59:59`;
40+
}
41+
return this.apiService.get(`/workspaces/${workspaceId}/fyle/expenses/`, params);
3142
}
3243

3344
getExpenseGroups(state: TaskLogState, limit: number, offset: number, selectedDateFilter: SelectedDateFilter | null, exportedAt?: string | null): Observable<ExpenseGroupResponse> {

src/app/integrations/business-central/business-central-main/business-central-export-log/business-central-skipped-export-log/business-central-skipped-export-log.component.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ export class BusinessCentralSkippedExportLogComponent implements OnInit {
6161
this.paginatorService.storePageSize(PaginatorPage.EXPORT_LOG, limit);
6262
}
6363

64-
return this.exportLogService.getSkippedExpenses(limit, offset).subscribe((skippedExpenses: SkipExportLogResponse) => {
64+
return this.exportLogService.getSkippedExpenses(limit, offset, this.selectedDateFilter).subscribe((skippedExpenses: SkipExportLogResponse) => {
6565
if (!this.isDateSelected) {
6666
this.totalCount = skippedExpenses.count;
6767
}

src/app/integrations/qbo/qbo-main/qbo-export-log/qbo-skipped-export-log/qbo-skipped-export-log.component.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export class QboSkippedExportLogComponent implements OnInit {
6363
this.paginatorService.storePageSize(PaginatorPage.EXPORT_LOG, limit);
6464
}
6565

66-
return this.exportLogService.getSkippedExpenses(limit, offset).subscribe((skippedExpenses: SkipExportLogResponse) => {
66+
return this.exportLogService.getSkippedExpenses(limit, offset, this.selectedDateFilter).subscribe((skippedExpenses: SkipExportLogResponse) => {
6767
if (!this.isDateSelected) {
6868
this.totalCount = skippedExpenses.count;
6969
}

src/app/integrations/sage300/sage300-main/sage300-export-log/sage300-skipped-export-log/sage300-skipped-export-log.component.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ export class Sage300SkippedExportLogComponent implements OnInit {
6666
this.paginatorService.storePageSize(PaginatorPage.EXPORT_LOG, limit);
6767
}
6868

69-
return this.exportLogService.getSkippedExpenses(limit, offset).subscribe((skippedExpenses: SkipExportLogResponse) => {
69+
return this.exportLogService.getSkippedExpenses(limit, offset, this.selectedDateFilter).subscribe((skippedExpenses: SkipExportLogResponse) => {
7070
if (!this.isDateSelected) {
7171
this.totalCount = skippedExpenses.count;
7272
}

0 commit comments

Comments
 (0)