Skip to content

Commit 8da584f

Browse files
authored
C1: Fix for Sentence Cases Misses (#586)
* Fix for Sentence Cases Misses * step name for export * step name and memoLabel * custom field texts * bill/ccp date as * sentence case pipe and stepper * updated the key * stepper done for first two sentence cases * pr comment * lint fix
1 parent 145f73b commit 8da584f

File tree

18 files changed

+130
-35
lines changed

18 files changed

+130
-35
lines changed

src/app/branding/branding-config.ts

Lines changed: 33 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,12 @@ export const brandingDemoVideoLinks = demoVideoLinks[brandingConfig.brandId];
203203
const content: ContentConfiguration = {
204204
fyle: {
205205
configuration: {
206+
connector: {
207+
stepName: 'Connect to Quickbooks Online'
208+
},
209+
employeeSetting: {
210+
stepName: 'Map Employees'
211+
},
206212
exportSetting: {
207213
stepName: 'Export Settings',
208214
headerText: 'Export Corporate Card Expenses',
@@ -211,7 +217,8 @@ const content: ContentConfiguration = {
211217
sectionLabel: '',
212218
subLabel: '',
213219
exportSubLabel: '',
214-
defaultCCCAccountLabel: '',
220+
defaultCCCAccountLabel: 'Set Default Credit Card Account as',
221+
defaultDebitCardAccountLabel: 'Set Default Debit Card Account as',
215222
defaultCCCVendorLabel: 'Set default corporate Card Vendor as',
216223
accountsPayableLabel: 'To which Accounts Payable account should the ',
217224
accountsPayableSubLabel: ' to the selected Accounts Payable Account.',
@@ -243,7 +250,8 @@ const content: ContentConfiguration = {
243250
singleCreditLineJELabel: 'Create a single itemized offset credit entry for Journal',
244251
singleCreditLineJESubLabel: 'Merge all Credits in a Journal to create a single entry.',
245252
billPaymentAccountLabel: 'To which Payment account should the payment entries be posted?',
246-
billPaymentAccountSubLabel: ', the payment entries will be posted to the selected Payment account in '
253+
billPaymentAccountSubLabel: ', the payment entries will be posted to the selected Payment account in ',
254+
memoStructureLabel: 'Set the line item-level Description Field in QuickBooks Online'
247255
},
248256
done: {
249257
ctaText: 'Launch Integration',
@@ -288,11 +296,22 @@ const content: ContentConfiguration = {
288296
viewExpenseText: 'View Expense',
289297
corporateCard: 'Corporate Card',
290298
errors: 'Errors',
291-
autoMap: 'Auto Map'
299+
autoMap: 'Auto Map',
300+
customField: 'Add new Custom Field',
301+
customFieldName: 'Field Name',
302+
customFieldPlaceholderName: 'Placeholder Name',
303+
customFieldType: 'Field Type',
304+
customFieldCreateandSave: 'Create and save'
292305
}
293306
},
294307
co: {
295308
configuration: {
309+
connector: {
310+
stepName: 'Connect to Quickbooks Online'
311+
},
312+
employeeSetting: {
313+
stepName: 'Map employees'
314+
},
296315
exportSetting: {
297316
stepName: 'Export settings',
298317
headerText: 'Export corporate card expenses',
@@ -301,7 +320,8 @@ const content: ContentConfiguration = {
301320
sectionLabel: '',
302321
subLabel: '',
303322
exportSubLabel: '',
304-
defaultCCCAccountLabel: '',
323+
defaultCCCAccountLabel: 'Set default credit card account as',
324+
defaultDebitCardAccountLabel: 'Set default debit card account as',
305325
defaultCCCVendorLabel: 'Set default corporate card vendor as',
306326
accountsPayableLabel: 'To which accounts payable account should the ',
307327
accountsPayableSubLabel: ' to the selected accounts payable Account.',
@@ -333,7 +353,8 @@ const content: ContentConfiguration = {
333353
singleCreditLineJELabel: 'Create a single itemized offset credit entry for journal',
334354
singleCreditLineJESubLabel: 'Merge all credits in a journal to create a single entry.',
335355
billPaymentAccountLabel: 'To which payment account should the payment entries be posted?',
336-
billPaymentAccountSubLabel: ', the payment entries will be posted to the selected payment account in '
356+
billPaymentAccountSubLabel: ', the payment entries will be posted to the selected payment account in ',
357+
memoStructureLabel: 'Set the line item-level description field in QuickBooks Online'
337358
},
338359
done: {
339360
ctaText: 'Launch integration',
@@ -378,7 +399,13 @@ const content: ContentConfiguration = {
378399
viewExpenseText: 'View expense',
379400
corporateCard: 'Corporate card',
380401
errors: 'errors',
381-
autoMap: 'Auto map'
402+
autoMap: 'Auto map',
403+
customField: 'Add new custom field',
404+
customFieldName: 'Field name',
405+
customFieldPlaceholderName: 'Placeholder name',
406+
customFieldType: 'Field type',
407+
customFieldCreateandSave: 'Create and save'
408+
382409
}
383410
}
384411
};

src/app/core/models/branding/content-configuration.model.ts

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
export type ContentConfiguration = {
22
[brandingId: string]: {
33
configuration: {
4+
connector: {
5+
stepName: string;
6+
},
7+
employeeSetting: {
8+
stepName: string;
9+
},
410
exportSetting: {
511
stepName: string;
612
headerText: string;
@@ -10,6 +16,7 @@ export type ContentConfiguration = {
1016
subLabel: string;
1117
exportSubLabel: string;
1218
defaultCCCAccountLabel: string;
19+
defaultDebitCardAccountLabel: string;
1320
defaultCCCVendorLabel: string;
1421
accountsPayableLabel: string;
1522
accountsPayableSubLabel: string;
@@ -42,6 +49,7 @@ export type ContentConfiguration = {
4249
singleCreditLineJESubLabel: string;
4350
billPaymentAccountLabel: string;
4451
billPaymentAccountSubLabel: string;
52+
memoStructureLabel: string;
4553
},
4654
done: {
4755
ctaText: string;
@@ -87,6 +95,11 @@ export type ContentConfiguration = {
8795
corporateCard: string;
8896
errors: string;
8997
autoMap: string;
98+
customField: string;
99+
customFieldName: string;
100+
customFieldPlaceholderName: string;
101+
customFieldType: string;
102+
customFieldCreateandSave: string;
90103
}
91104
}
92105
}

src/app/core/models/qbo/qbo-configuration/qbo-onboarding.model.ts

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { brandingFeatureConfig } from "src/app/branding/branding-config";
1+
import { brandingContent, brandingFeatureConfig } from "src/app/branding/branding-config";
22
import { QBOOnboardingState } from "../../enum/enum.model";
33
import { OnboardingStepper } from "../../misc/onboarding-stepper.model";
44

@@ -13,43 +13,45 @@ type QBOOnboardingStepperMap = {
1313
}
1414

1515
export class QBOOnboardingModel {
16+
brandingContent = brandingContent.configuration;
17+
1618
private onboardingSteps: OnboardingStepper[] = [
1719
{
1820
active: false,
1921
completed: false,
20-
step: 'Connect to QuickBooks Online',
22+
step: brandingContent.configuration.connector.stepName,
2123
icon: 'link-vertical-medium',
2224
route: '/integrations/qbo/onboarding/connector',
2325
styleClasses: ['step-name-connector--text']
2426
},
2527
{
2628
active: false,
2729
completed: false,
28-
step: 'Map Employees',
30+
step: brandingContent.configuration.employeeSetting.stepName,
2931
icon: 'mapping-medium',
3032
route: '/integrations/qbo/onboarding/employee_settings',
3133
styleClasses: ['step-name-export--text']
3234
},
3335
{
3436
active: false,
3537
completed: false,
36-
step: 'Export Settings',
38+
step: brandingContent.configuration.exportSetting.stepName,
3739
icon: 'arrow-tail-up-medium',
3840
route: '/integrations/qbo/onboarding/export_settings',
3941
styleClasses: ['step-name-export--text']
4042
},
4143
{
4244
active: false,
4345
completed: false,
44-
step: 'Import Settings',
46+
step: brandingContent.configuration.importSetting.stepName,
4547
icon: 'arrow-tail-down-medium',
4648
route: '/integrations/qbo/onboarding/import_settings',
4749
styleClasses: ['step-name-export--text']
4850
},
4951
{
5052
active: false,
5153
completed: false,
52-
step: 'Advanced Settings',
54+
step: brandingContent.configuration.advancedSettings.stepName,
5355
icon: 'gear-medium',
5456
route: '/integrations/qbo/onboarding/advanced_settings',
5557
styleClasses: ['step-name-advanced--text']

src/app/integrations/qbo/qbo-onboarding/qbo-onboarding-advanced-settings/qbo-onboarding-advanced-settings.component.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { Component, OnInit } from '@angular/core';
2+
import { brandingContent } from 'src/app/branding/branding-config';
23
import { OnboardingStepper } from 'src/app/core/models/misc/onboarding-stepper.model';
34
import { QBOOnboardingModel } from 'src/app/core/models/qbo/qbo-configuration/qbo-onboarding.model';
45
import { WorkspaceService } from 'src/app/core/services/common/workspace.service';
@@ -10,7 +11,9 @@ import { WorkspaceService } from 'src/app/core/services/common/workspace.service
1011
})
1112
export class QboOnboardingAdvancedSettingsComponent implements OnInit {
1213

13-
onboardingSteps: OnboardingStepper[] = new QBOOnboardingModel().getOnboardingSteps('Advanced Settings', this.workspaceService.getOnboardingState());
14+
brandingContent = brandingContent.configuration.advancedSettings;
15+
16+
onboardingSteps: OnboardingStepper[] = new QBOOnboardingModel().getOnboardingSteps(this.brandingContent.stepName, this.workspaceService.getOnboardingState());
1417

1518
constructor(
1619
private workspaceService: WorkspaceService

src/app/integrations/qbo/qbo-onboarding/qbo-onboarding-connector/qbo-onboarding-connector.component.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { Component, OnDestroy, OnInit } from '@angular/core';
22
import { ActivatedRoute, Router } from '@angular/router';
33
import { ConfirmEventType } from 'primeng/api';
44
import { Subscription } from 'rxjs';
5-
import { brandingConfig, brandingFeatureConfig, brandingKbArticles } from 'src/app/branding/branding-config';
5+
import { brandingConfig, brandingContent, brandingFeatureConfig, brandingKbArticles } from 'src/app/branding/branding-config';
66
import { BrandingConfiguration } from 'src/app/core/models/branding/branding-configuration.model';
77
import { CloneSettingExist } from 'src/app/core/models/common/clone-setting.model';
88
import { ConfigurationCta, ConfigurationWarningEvent, QBOOnboardingState, ToastSeverity } from 'src/app/core/models/enum/enum.model';
@@ -28,7 +28,9 @@ import { environment } from 'src/environments/environment';
2828
})
2929
export class QboOnboardingConnectorComponent implements OnInit, OnDestroy {
3030

31-
onboardingSteps: OnboardingStepper[] = new QBOOnboardingModel().getOnboardingSteps('Connect to QuickBooks Online', this.workspaceService.getOnboardingState());
31+
brandingContent = brandingContent.configuration.connector;
32+
33+
onboardingSteps: OnboardingStepper[] = new QBOOnboardingModel().getOnboardingSteps(this.brandingContent.stepName, this.workspaceService.getOnboardingState());
3234

3335
isLoading: boolean = true;
3436

src/app/integrations/qbo/qbo-onboarding/qbo-onboarding-employee-settings/qbo-onboarding-employee-settings.component.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { Component, OnInit } from '@angular/core';
2+
import { brandingContent } from 'src/app/branding/branding-config';
23
import { OnboardingStepper } from 'src/app/core/models/misc/onboarding-stepper.model';
34
import { QBOOnboardingModel } from 'src/app/core/models/qbo/qbo-configuration/qbo-onboarding.model';
45
import { WorkspaceService } from 'src/app/core/services/common/workspace.service';
@@ -10,7 +11,9 @@ import { WorkspaceService } from 'src/app/core/services/common/workspace.service
1011
})
1112
export class QboOnboardingEmployeeSettingsComponent implements OnInit {
1213

13-
onboardingSteps: OnboardingStepper[] = new QBOOnboardingModel().getOnboardingSteps('Map Employees', this.workspaceService.getOnboardingState());
14+
brandingContent = brandingContent.configuration.employeeSetting;
15+
16+
onboardingSteps: OnboardingStepper[] = new QBOOnboardingModel().getOnboardingSteps(this.brandingContent.stepName, this.workspaceService.getOnboardingState());
1417

1518
constructor(
1619
private workspaceService: WorkspaceService

src/app/integrations/qbo/qbo-onboarding/qbo-onboarding-export-settings/qbo-onboarding-export-settings.component.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { Component, OnInit } from '@angular/core';
2+
import { brandingContent } from 'src/app/branding/branding-config';
23
import { OnboardingStepper } from 'src/app/core/models/misc/onboarding-stepper.model';
34
import { QBOOnboardingModel } from 'src/app/core/models/qbo/qbo-configuration/qbo-onboarding.model';
45
import { WorkspaceService } from 'src/app/core/services/common/workspace.service';
@@ -10,7 +11,9 @@ import { WorkspaceService } from 'src/app/core/services/common/workspace.service
1011
})
1112
export class QboOnboardingExportSettingsComponent implements OnInit {
1213

13-
onboardingSteps: OnboardingStepper[] = new QBOOnboardingModel().getOnboardingSteps('Export Settings', this.workspaceService.getOnboardingState());
14+
brandingContent = brandingContent.configuration.exportSetting;
15+
16+
onboardingSteps: OnboardingStepper[] = new QBOOnboardingModel().getOnboardingSteps(this.brandingContent.stepName, this.workspaceService.getOnboardingState());
1417

1518
constructor(
1619
private workspaceService: WorkspaceService

src/app/integrations/qbo/qbo-onboarding/qbo-onboarding-import-settings/qbo-onboarding-import-settings.component.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { Component, OnInit } from '@angular/core';
2+
import { brandingContent } from 'src/app/branding/branding-config';
23
import { OnboardingStepper } from 'src/app/core/models/misc/onboarding-stepper.model';
34
import { QBOOnboardingModel } from 'src/app/core/models/qbo/qbo-configuration/qbo-onboarding.model';
45
import { WorkspaceService } from 'src/app/core/services/common/workspace.service';
@@ -10,7 +11,9 @@ import { WorkspaceService } from 'src/app/core/services/common/workspace.service
1011
})
1112
export class QboOnboardingImportSettingsComponent implements OnInit {
1213

13-
onboardingSteps: OnboardingStepper[] = new QBOOnboardingModel().getOnboardingSteps('Import Settings', this.workspaceService.getOnboardingState());
14+
brandingContent = brandingContent.configuration.importSetting;
15+
16+
onboardingSteps: OnboardingStepper[] = new QBOOnboardingModel().getOnboardingSteps(this.brandingContent.stepName, this.workspaceService.getOnboardingState());
1417

1518
constructor(
1619
private workspaceService: WorkspaceService

src/app/integrations/qbo/qbo-shared/qbo-advanced-settings/qbo-advanced-settings.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<div *ngIf="!isLoading" class="configuration--contents tw-border-border-tertiary tw-mt-6" [ngClass]="{'tw-mx-120-px tw-shadow-app-card': brandingConfig.brandId === 'fyle', 'tw-mx-60-px tw-shadow-shadow-level-1': brandingConfig.brandId === 'co'}">
55
<div>
66
<app-configuration-step-header
7-
[headerText]="'Advanced Settings'"
7+
[headerText]="brandingContent.stepName"
88
[contentText]="'In this section, you can customize the integration based on your accounting requirements. '"
99
[redirectLink]="supportArticleLink"
1010
[showSyncButton]="isOnboarding"
@@ -120,7 +120,7 @@
120120
[form]="advancedSettingForm"
121121
[isFieldMandatory]="false"
122122
[mandatoryErrorListName]="'Item level description'"
123-
[label]="'Set the line item-level Description Field in QuickBooks Online'"
123+
[label]="brandingContent.memoStructureLabel"
124124
[subLabel]="'You can choose from a list of available data points that you\'d like to export to the description field in QuickBooks Online and re-order them as per your requirement.'"
125125
[options]="defaultMemoOptions"
126126
[iconPath]="'list'"

src/app/integrations/qbo/qbo-shared/qbo-export-settings/qbo-export-settings.component.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<div *ngIf="!isLoading" class="configuration--contents tw-border-border-tertiary tw-mt-6" [ngClass]="{'tw-mx-120-px tw-shadow-app-card': brandingConfig.brandId === 'fyle', 'tw-mx-60-px tw-shadow-shadow-level-1': brandingConfig.brandId === 'co'}">
66
<div>
77
<app-configuration-step-header
8-
[headerText]="'Export Settings'"
8+
[headerText]="brandingContent.stepName"
99
[contentText]="'In this section, you will configure how and when expenses from ' + brandingConfig.brandName + ' can be exported to QuickBooks Online'"
1010
[redirectLink]="redirectLink"
1111
[showSyncButton]="isOnboarding"
@@ -182,7 +182,7 @@
182182
[iconPath]="'list'"
183183
[isFieldMandatory]="true"
184184
[mandatoryErrorListName]="'credit card account'"
185-
[label]="'Set Default Credit Card Account as'"
185+
[label]="brandingContent.corporateCard.defaultCCCAccountLabel"
186186
[subLabel]="'Post all your company corporate card transactions to a default credit card account.'"
187187
[placeholder]="'Select Default Credit Card Account'"
188188
[formControllerName]="'defaultCCCAccount'">
@@ -197,7 +197,7 @@
197197
[iconPath]="'list'"
198198
[isFieldMandatory]="true"
199199
[mandatoryErrorListName]="'debit card account'"
200-
[label]="'Set Default Debit Card Account as'"
200+
[label]="brandingContent.corporateCard.defaultDebitCardAccountLabel"
201201
[subLabel]="'Post all your company debit card transactions to a default debit card account.'"
202202
[placeholder]="'Select Default Debit Card Account'"
203203
[formControllerName]="'defaultDebitCardAccount'">
@@ -268,7 +268,7 @@
268268
[form]="exportSettingForm"
269269
[isFieldMandatory]="true"
270270
[mandatoryErrorListName]="'export date'"
271-
[label]="'Set the ' + (exportSettingForm.value.creditCardExportType | snakeCaseToSpaceCase | titlecase) + ' date as'"
271+
[label]=" 'Set the ' + (brandingConfig.brandId === 'fyle' ? (exportSettingForm.value.creditCardExportType | snakeCaseToSpaceCase | titlecase) : (exportSettingForm.value.creditCardExportType | lowercase)) + ' date as'"
272272
[subLabel]="'The selected date will reflect in the corporate card expenses exported to QuickBooks Online.'"
273273
[options]="cccExpenseGroupingDateOptions"
274274
[iconPath]="'calendar'"

src/app/integrations/qbo/qbo-shared/qbo-import-settings/qbo-import-settings.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
</div>
44
<div *ngIf="!isLoading" class="configuration--contents tw-border-border-tertiary tw-mt-6" [ngClass]="{'tw-mx-120-px tw-shadow-app-card': brandingConfig.brandId === 'fyle', 'tw-mx-60-px tw-shadow-shadow-level-1': brandingConfig.brandId === 'co'}">
55
<div>
6-
<app-configuration-step-header [headerText]="'Import Settings'"
6+
<app-configuration-step-header [headerText]="brandingContent.stepName"
77
[contentText]="'In this section, you can choose the fields required to be imported from QuickBooks Online to ' + brandingConfig.brandName + '. '"
88
[redirectLink]="supportArticleLink" [showSyncButton]="isOnboarding" [appName]="appName"
99
(refreshDimension)="refreshDimensions()">

0 commit comments

Comments
 (0)