PR Comments

fylein · May 22, 2024 · 9b9742b · 9b9742b
1 parent 3a0158d
commit 9b9742b
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 63 deletions.
diff --git a/src/app/app.module.ts b/src/app/app.module.ts
@@ -18,7 +18,6 @@ import { SharedModule } from './shared/shared.module';
 import { RippleModule } from 'primeng/ripple';
 import { BrandingService } from './core/services/common/branding.service';
 import { Sage300ConfigurationModule } from './integrations/sage300/sage300-main/sage300-configuration/sage300-configuration.module';
-import { HttpErrorInterceptor } from './core/interceptor/http-error.interceptor';
 
 @NgModule({
   declarations: [
@@ -47,11 +46,6 @@ import { HttpErrorInterceptor } from './core/interceptor/http-error.interceptor'
       useClass: JwtInterceptor,
       multi: true
     },
-    {
-      provide: HTTP_INTERCEPTORS,
-      useClass: HttpErrorInterceptor,
-      multi: true
-    },
     {
       provide: ErrorHandler,
       useClass: GlobalErrorHandler

diff --git a/src/app/core/interceptor/http-error.interceptor.spec.ts b/src/app/core/interceptor/http-error.interceptor.spec.ts
diff --git a/src/app/core/interceptor/http-error.interceptor.ts b/src/app/core/interceptor/http-error.interceptor.ts
diff --git a/src/app/core/services/common/api.service.ts b/src/app/core/services/common/api.service.ts
@@ -26,12 +26,18 @@ export class ApiService {
   }
 
   private handleError(error: HttpErrorResponse, httpMethod: string, url: string) {
-    if (error.error instanceof ErrorEvent) {
-      console.error('An error occurred:', error.error.message);
+    if (httpMethod === 'POST') {
+      if (error.status >= 500) {
+        console.error(`POST error ${error.status}: ${error.message}`);
+      }
+    } else if (httpMethod === 'GET') {
+      if (error.status !== 404) {
+        console.error(`GET error ${error.status}: ${error.message}`);
+      }
+      // Else (404 GET error) - do not log
     } else {
-      console.error(
-        `Backend returned code ${error.status}, url was: ${url} method was: ${httpMethod}, body was: ${JSON.stringify(error.error)}`
-      );
+      // For other HTTP methods, you can add custom logic or just log the errors
+      console.error(`HTTP ${httpMethod} error ${error.status}: ${error.message}`);
     }
     return throwError(error);
   }