Skip to content

Commit a9425c7

Browse files
anishfyleanishfyle
authored andcommitted
fix bugs (#1119)
1 parent 51694ef commit a9425c7

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

src/app/core/models/common/advanced-settings.model.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
import { FormControl, FormGroup } from "@angular/forms";
2-
import { JoinOption, Operator } from "../enum/enum.model";
2+
import { AppName, JoinOption, Operator } from "../enum/enum.model";
33
import { environment } from "src/environments/environment";
44
import { ExportSettingGet } from "../intacct/intacct-configuration/export-settings.model";
55
import { QBOExportSettingGet } from "../qbo/qbo-configuration/qbo-export-setting.model";
66
import { NetSuiteExportSettingGet } from "../netsuite/netsuite-configuration/netsuite-export-setting.model";
7+
import { IntacctConfiguration } from "../db/configuration.model";
78

89
export type EmailOption = {
910
email: string;
@@ -75,17 +76,19 @@ export class AdvancedSettingsModel {
7576
return ['employee_email', 'employee_name', 'merchant', 'purpose', 'category', 'spent_on', 'report_number', 'expense_link', 'card_number'];
7677
}
7778

78-
static getMemoOptions(exportSettings: ExportSettingGet | NetSuiteExportSettingGet | QBOExportSettingGet, appName: string): string[] {
79+
static getMemoOptions(exportSettings: IntacctConfiguration | ExportSettingGet | NetSuiteExportSettingGet | QBOExportSettingGet, appName: string): string[] {
7980
const defaultOptions = this.getDefaultMemoOptions();
8081
let cccExportType: string | undefined;
8182
// Handle both configurations and configuration properties
82-
if ('configurations' in exportSettings) {
83+
if (appName === AppName.INTACCT) {
84+
cccExportType = (exportSettings as IntacctConfiguration).corporate_credit_card_expenses_object ?? undefined;
85+
} else if ('configurations' in exportSettings) {
8386
cccExportType = exportSettings.configurations?.corporate_credit_card_expenses_object ?? undefined;
8487
} else if ('workspace_general_settings' in exportSettings) {
8588
cccExportType = exportSettings.workspace_general_settings?.corporate_credit_card_expenses_object ?? undefined;
8689
}
8790
// Filter out options based on cccExportType and appName
88-
if (cccExportType && ['netsuite', 'qbo', 'sage intacct'].includes(appName.toLowerCase())) {
91+
if (cccExportType && ['netsuite', 'quickbooks online', 'sage intacct'].includes(appName.toLowerCase())) {
8992
return defaultOptions; // Allow all options including 'card_number'
9093
}
9194
return defaultOptions.filter(option => option !== 'card_number'); // Omit 'card_number' for other apps

src/app/integrations/intacct/intacct-shared/intacct-advanced-settings/intacct-advanced-settings.component.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ export class IntacctAdvancedSettingsComponent implements OnInit {
9393

9494
private sessionStartTime = new Date();
9595

96-
defaultMemoFields: string[] = ['employee_email', 'merchant', 'purpose', 'category', 'spent_on', 'report_number', 'expense_link'];
96+
defaultMemoFields: string[] = AdvancedSettingsModel.getDefaultMemoOptions();
9797

9898
paymentSyncOptions: AdvancedSettingFormOption[] = [
9999
{
@@ -313,6 +313,7 @@ export class IntacctAdvancedSettingsComponent implements OnInit {
313313
if (this.advancedSettings.workspace_schedules?.additional_email_options) {
314314
this.adminEmails = this.adminEmails.concat(this.advancedSettings.workspace_schedules?.additional_email_options);
315315
}
316+
this.defaultMemoFields = AdvancedSettingsModel.getMemoOptions(configuration, AppName.INTACCT);
316317
this.initializeAdvancedSettingsFormWithData(!!expenseFilter.count);
317318
this.initializeSkipExportForm();
318319
this.isLoading = false;

0 commit comments

Comments
 (0)