test and datafixes

Author: mvaishnavi

src/app/fyle/add-edit-per-diem/add-edit-per-diem.page.ts

@@ -892,10 +892,6 @@ export class AddEditPerDiemPage implements OnInit {
       map((orgSettings) => orgSettings.advanced_per_diems_settings?.enable_employee_restriction)
     );
 
-    orgSettings$.subscribe((orgSettings) => {
-
-    });
-
     this.setupNetworkWatcher();
 
     this.recentlyUsedValues$ = this.isConnected$.pipe(

src/app/fyle/dashboard/stats/stats.component.spec.ts

@@ -183,7 +183,7 @@ describe('StatsComponent', () => {
         expect(dashboardService.getReportsStats).toHaveBeenCalledTimes(1);
         expect(orgSettingsService.get).toHaveBeenCalledTimes(1);
         expect(paymentModeService.isNonReimbursableOrg).toHaveBeenCalledOnceWith(
-          orgSettingsParamsWithSimplifiedReport.payment_mode_settings
+          orgSettingsRes.payment_mode_settings
         );
         expect(component.reportStatsLoading).toBeFalse();
         done();

src/app/fyle/my-expenses/my-expenses.page.ts

@@ -495,7 +495,6 @@ export class MyExpensesPage implements OnInit {
     this.isPerDiemEnabled$ = this.orgSettings$.pipe(map((orgSettings) => orgSettings?.per_diem?.enabled));
 
     this.orgSettings$.subscribe((orgSettings) => {
-  
       this.restrictPendingTransactionsEnabled =
         (orgSettings?.corporate_credit_card_settings?.enabled &&
           orgSettings.pending_cct_expense_restriction?.enabled) ||

src/app/fyle/my-view-report/my-view-report.page.ts

@@ -23,7 +23,6 @@ import { Expense } from 'src/app/core/models/platform/v1/expense.model';
 import { ExpenseView } from 'src/app/core/models/expense-view.enum';
 import { OrgSettingsService } from 'src/app/core/services/org-settings.service';
 import { ReportPageSegment } from 'src/app/core/enums/report-page-segment.enum';
-import { OrgSettings } from 'src/app/core/models/org-settings.model';
 import { ExtendedOrgUser } from 'src/app/core/models/extended-org-user.model';
 import { ExpensesService } from 'src/app/core/services/platform/v1/spender/expenses.service';
 import { AddExpensesToReportComponent } from './add-expenses-to-report/add-expenses-to-report.component';

src/app/fyle/team-reports/team-reports.page.ts

@@ -130,9 +130,6 @@ export class TeamReportsPage implements OnInit {
       this.teamReportsTaskCount = teamReportsTaskCount;
     });
 
-    const orgSettings$ = this.orgSettingsService.get().pipe(shareReplay(1));
-
-
     this.eou$.subscribe((eou: ExtendedOrgUser) => {
       this.loadData$ = new BehaviorSubject({
         pageNumber: 1,

src/app/fyle/view-expense/view-expense.page.ts

@@ -395,7 +395,6 @@ export class ViewExpensePage {
       this.isRTFEnabled =
         (orgSettings.visa_enrollment_settings.allowed && orgSettings.visa_enrollment_settings.enabled) ||
         (orgSettings.mastercard_enrollment_settings.allowed && orgSettings.mastercard_enrollment_settings.enabled);
-              
     });
 
     this.expenseFieldsService

src/app/fyle/view-mileage/view-mileage.page.ts

@@ -374,7 +374,6 @@ export class ViewMileagePage {
       .pipe(shareReplay(1))
       .subscribe((orgSettings) => {
         this.orgSettings = orgSettings;
-        
       });
 
     this.mileageCustomFields$ = this.mileageExpense$.pipe(

src/app/shared/components/fy-add-to-report/fy-add-to-report-modal/fy-add-to-report-modal.component.ts

@@ -51,7 +51,7 @@ export class FyAddToReportModalComponent implements OnInit, AfterViewInit {
     private currencyService: CurrencyService
   ) {}
 
-  ngOnInit() {
+  ngOnInit(): void {
     if (this.currentSelection) {
       this.options = this.options
         .map((option) =>
@@ -65,23 +65,23 @@ export class FyAddToReportModalComponent implements OnInit, AfterViewInit {
     });
   }
 
-  ngAfterViewInit() {
+  ngAfterViewInit(): void {
     this.cdr.detectChanges();
   }
 
-  onDoneClick() {
+  onDoneClick(): void {
     this.modalController.dismiss();
   }
 
-  onElementSelect(option: Option) {
+  onElementSelect(option: Option): void {
     this.modalController.dismiss(option);
   }
 
-  createDraftReport() {
+  createDraftReport(): void {
     this.modalController.dismiss({ createDraftReport: true });
   }
 
-  dismissModal(event: { srcElement: { innerText: string } }) {
+  dismissModal(event: { srcElement: { innerText: string } }): void {
     this.modalController.dismiss({
       label: event.srcElement.innerText,
       value: null,

src/app/shared/components/fy-filters/fy-filters.component.ts

@@ -3,7 +3,7 @@ import { FilterOptions } from './filter-options.interface';
 import { SelectedFilters } from './selected-filters.interface';
 import { FilterOptionType } from './filter-option-type.enum';
 import { ModalController } from '@ionic/angular';
-import { forkJoin, Observable, of } from 'rxjs';
+import { Observable, of } from 'rxjs';
 
 @Component({
   selector: 'app-fy-filters',