fix: fix onboarding test for error popover (#3452)

Author: bistaastha

src/app/fyle/spender-onboarding/spender-onboarding-connect-card-step/spender-onboarding-connect-card-step.component.spec.ts

@@ -257,7 +257,7 @@ describe('SpenderOnboardingConnectCardStepComponent', () => {
       fixture.detectChanges();
       const message = component.generateMessage();
       expect(message).toBe(
-        `We ran into an issue while processing your request for the cards  **** 1234, **** 5678 and **** 9012.<br><br>You can cancel and retry connecting the failed card or proceed to the next step.`
+        `We ran into an issue while processing your request for the cards <span class='text-bold'>**** 1234, **** 5678</span> and <span class='text-bold'>**** 9012</span>.<br><br>You can cancel and retry connecting the failed card or proceed to the next step.`
       );
     });
 
@@ -269,7 +269,7 @@ describe('SpenderOnboardingConnectCardStepComponent', () => {
       const message = component.generateMessage();
 
       expect(message).toBe(
-        `We ran into an issue while processing your request for the card **** 1234.<br><br> You can cancel and retry connecting the failed card or proceed to the next step.`
+        `We ran into an issue while processing your request for the card <span class='text-bold'>**** 1234</span>.<br><br> You can cancel and retry connecting the failed card or proceed to the next step.`
       );
     });
   });
@@ -372,19 +372,19 @@ describe('SpenderOnboardingConnectCardStepComponent', () => {
       };
       const popoverSpy = jasmine.createSpyObj('popover', ['present', 'onWillDismiss']);
       spyOn(component, 'generateMessage').and.returnValue('Error message');
-      const isStepSkippedSpy = spyOn(component.isStepSkipped, 'emit');
+      const isStepCompleteSpy = spyOn(component.isStepComplete, 'emit');
       popoverSpy.onWillDismiss.and.resolveTo({
         data: {
           action: 'close',
         },
       });
       popoverController.create.and.resolveTo(popoverSpy);
-      fixture.detectChanges();
       component.showErrorPopover();
+      tick();
 
       expect(popoverController.create).toHaveBeenCalledOnceWith(enrollmentErrorPopoverData2);
       tick();
-      expect(isStepSkippedSpy).toHaveBeenCalledTimes(1);
+      expect(isStepCompleteSpy).toHaveBeenCalledTimes(1);
     }));
 
     it('should handle cancel action', () => {

src/app/fyle/spender-onboarding/spender-onboarding-connect-card-step/spender-onboarding-connect-card-step.component.ts

@@ -132,9 +132,9 @@ export class SpenderOnboardingConnectCardStepComponent implements OnInit, OnChan
     } else if (this.cardsList.failedCards.length > 1) {
       const allButLast = this.cardsList.failedCards.slice(0, -1).join(', ');
       const lastCard = this.cardsList.failedCards[this.cardsList.failedCards.length - 1];
-      return `We ran into an issue while processing your request for the cards  ${allButLast} and ${lastCard}.<br><br>You can cancel and retry connecting the failed card or proceed to the next step.`;
+      return `We ran into an issue while processing your request for the cards <span class='text-bold'>${allButLast}</span> and <span class='text-bold'>${lastCard}</span>.<br><br>You can cancel and retry connecting the failed card or proceed to the next step.`;
     } else {
-      return `We ran into an issue while processing your request for the card ${this.cardsList.failedCards[0]}.<br><br> You can cancel and retry connecting the failed card or proceed to the next step.`;
+      return `We ran into an issue while processing your request for the card <span class='text-bold'>${this.cardsList.failedCards[0]}</span>.<br><br> You can cancel and retry connecting the failed card or proceed to the next step.`;
     }
   }
 
@@ -167,10 +167,12 @@ export class SpenderOnboardingConnectCardStepComponent implements OnInit, OnChan
       action: string;
     }>;
 
-    if (!data && this.cardsList.successfulCards.length > 0) {
+    if (this.cardsList.successfulCards.length > 0) {
+      this.trackingService.eventTrack('Connect Cards Onboarding Step - Completed', {
+        numberOfCards: this.cardsList.successfulCards.length,
+      });
       this.isStepComplete.emit(true);
-    }
-    if (data.action === 'close') {
+    } else if (data?.action === 'close') {
       this.isStepSkipped.emit(true);
     }
   }

src/global.scss

@@ -359,6 +359,10 @@ ion-popover.camera-options-popover {
   text-align: left !important;
 }
 
+.text-bold {
+  font-weight: 500;
+}
+
 .text-right {
   text-align: right !important;
 }