Attributes: use proper function for overwriting attributes

felixjulianheitmann · felixjulianheitmann · commit 1ecf32fd6b12 · 2024-07-09T14:52:58.000+02:00
diff --git a/include/spdlog/attributes.h b/include/spdlog/attributes.h
@@ -46,7 +46,7 @@ class SPDLOG_API log_attributes {
 
     void put(attr_map_t const& attributes) {
         auto lck = lock();
-        attrs.insert(attributes.begin(), attributes.end());
+        for (auto const& attribute : attributes) attrs.insert_or_assign(attribute.first, attribute.second);
     }
     void put(const key_t& key, const value_t& value) { put({{key, value}}); }
 

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ class SPDLOG_API log_attributes {`
`46`	`46`
`47`	`47`	`void put(attr_map_t const& attributes) {`
`48`	`48`	`auto lck = lock();`
`49`		`- attrs.insert(attributes.begin(), attributes.end());`
	`49`	`+ for (auto const& attribute : attributes) attrs.insert_or_assign(attribute.first, attribute.second);`
`50`	`50`	`}`
`51`	`51`	`void put(const key_t& key, const value_t& value) { put({{key, value}}); }`
`52`	`52`