Skip to content

Overflow at many places can happen #3484

@MariwanJ

Description

@MariwanJ

There are at many places this kind of lines:

 const uint32_t mod_inv_5 = 0xcccccccd;
 const uint32_t mod_inv_25 = mod_inv_5 * mod_inv_5;

for example :
format-inl.h
Which is obvious overflow happens and compiler complain all the time about it. I didn't try to understand the code but there should be a way to avoid overflow.
BR
Mariwan

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions