Skip to content

Commit 3f6627e

Browse files
SimonSchicksandersn
SimonSchick
authored and
sandersn
committed
feat(node): v12.7 (DefinitelyTyped#37217)
* feat(node): v12.7 * correct dns.lookup add http.response.writableFinished add tests fix lint * add events to http.ClientRequest
1 parent 6933743 commit 3f6627e

File tree

10 files changed

+1614
-1708
lines changed

10 files changed

+1614
-1708
lines changed

‎types/node/dns.d.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@ declare module "dns" {
3131

3232
// NOTE: This namespace provides design-time support for util.promisify. Exported members do not exist at runtime.
3333
namespace lookup {
34-
function __promisify__(hostname: string, options: LookupAllOptions): Promise<{ address: LookupAddress[] }>;
35-
function __promisify__(hostname: string, options?: LookupOneOptions | number): Promise<{ address: string, family: number }>;
36-
function __promisify__(hostname: string, options?: LookupOptions | number): Promise<{ address: string | LookupAddress[], family?: number }>;
34+
function __promisify__(hostname: string, options: LookupAllOptions): Promise<LookupAddress[]>;
35+
function __promisify__(hostname: string, options?: LookupOneOptions | number): Promise<LookupAddress>;
36+
function __promisify__(hostname: string, options: LookupOptions): Promise<LookupAddress | LookupAddress[]>;
3737
}
3838

3939
function lookupService(address: string, port: number, callback: (err: NodeJS.ErrnoException | null, hostname: string, service: string) => void): void;

‎types/node/http.d.ts

+91
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,7 @@ declare module "http" {
146146
class ServerResponse extends OutgoingMessage {
147147
statusCode: number;
148148
statusMessage: string;
149+
writableFinished: boolean;
149150

150151
constructor(req: IncomingMessage);
151152

@@ -158,6 +159,16 @@ declare module "http" {
158159
writeHead(statusCode: number, headers?: OutgoingHttpHeaders): this;
159160
}
160161

162+
interface InformationEvent {
163+
statusCode: number;
164+
statusMessage: string;
165+
httpVersion: string;
166+
httpVersionMajor: number;
167+
httpVersionMinor: number;
168+
headers: IncomingHttpHeaders;
169+
rawHeaders: string[];
170+
}
171+
161172
// https://github.com/nodejs/node/blob/master/lib/_http_client.js#L77
162173
class ClientRequest extends OutgoingMessage {
163174
connection: Socket;
@@ -172,6 +183,86 @@ declare module "http" {
172183
setTimeout(timeout: number, callback?: () => void): this;
173184
setNoDelay(noDelay?: boolean): void;
174185
setSocketKeepAlive(enable?: boolean, initialDelay?: number): void;
186+
187+
addListener(event: 'abort', listener: () => void): this;
188+
addListener(event: 'connect', listener: (response: IncomingMessage, socket: Socket, head: Buffer) => void): this;
189+
addListener(event: 'continue', listener: () => void): this;
190+
addListener(event: 'information', listener: (info: InformationEvent) => void): this;
191+
addListener(event: 'response', listener: (response: IncomingMessage) => void): this;
192+
addListener(event: 'socket', listener: (socket: Socket) => void): this;
193+
addListener(event: 'timeout', listener: () => void): this;
194+
addListener(event: 'upgrade', listener: (response: IncomingMessage, socket: Socket, head: Buffer) => void): this;
195+
addListener(event: 'close', listener: () => void): this;
196+
addListener(event: 'drain', listener: () => void): this;
197+
addListener(event: 'error', listener: (err: Error) => void): this;
198+
addListener(event: 'finish', listener: () => void): this;
199+
addListener(event: 'pipe', listener: (src: stream.Readable) => void): this;
200+
addListener(event: 'unpipe', listener: (src: stream.Readable) => void): this;
201+
addListener(event: string | symbol, listener: (...args: any[]) => void): this;
202+
203+
on(event: 'abort', listener: () => void): this;
204+
on(event: 'connect', listener: (response: IncomingMessage, socket: Socket, head: Buffer) => void): this;
205+
on(event: 'continue', listener: () => void): this;
206+
on(event: 'information', listener: (info: InformationEvent) => void): this;
207+
on(event: 'response', listener: (response: IncomingMessage) => void): this;
208+
on(event: 'socket', listener: (socket: Socket) => void): this;
209+
on(event: 'timeout', listener: () => void): this;
210+
on(event: 'upgrade', listener: (response: IncomingMessage, socket: Socket, head: Buffer) => void): this;
211+
on(event: 'close', listener: () => void): this;
212+
on(event: 'drain', listener: () => void): this;
213+
on(event: 'error', listener: (err: Error) => void): this;
214+
on(event: 'finish', listener: () => void): this;
215+
on(event: 'pipe', listener: (src: stream.Readable) => void): this;
216+
on(event: 'unpipe', listener: (src: stream.Readable) => void): this;
217+
on(event: string | symbol, listener: (...args: any[]) => void): this;
218+
219+
once(event: 'abort', listener: () => void): this;
220+
once(event: 'connect', listener: (response: IncomingMessage, socket: Socket, head: Buffer) => void): this;
221+
once(event: 'continue', listener: () => void): this;
222+
once(event: 'information', listener: (info: InformationEvent) => void): this;
223+
once(event: 'response', listener: (response: IncomingMessage) => void): this;
224+
once(event: 'socket', listener: (socket: Socket) => void): this;
225+
once(event: 'timeout', listener: () => void): this;
226+
once(event: 'upgrade', listener: (response: IncomingMessage, socket: Socket, head: Buffer) => void): this;
227+
once(event: 'close', listener: () => void): this;
228+
once(event: 'drain', listener: () => void): this;
229+
once(event: 'error', listener: (err: Error) => void): this;
230+
once(event: 'finish', listener: () => void): this;
231+
once(event: 'pipe', listener: (src: stream.Readable) => void): this;
232+
once(event: 'unpipe', listener: (src: stream.Readable) => void): this;
233+
once(event: string | symbol, listener: (...args: any[]) => void): this;
234+
235+
prependListener(event: 'abort', listener: () => void): this;
236+
prependListener(event: 'connect', listener: (response: IncomingMessage, socket: Socket, head: Buffer) => void): this;
237+
prependListener(event: 'continue', listener: () => void): this;
238+
prependListener(event: 'information', listener: (info: InformationEvent) => void): this;
239+
prependListener(event: 'response', listener: (response: IncomingMessage) => void): this;
240+
prependListener(event: 'socket', listener: (socket: Socket) => void): this;
241+
prependListener(event: 'timeout', listener: () => void): this;
242+
prependListener(event: 'upgrade', listener: (response: IncomingMessage, socket: Socket, head: Buffer) => void): this;
243+
prependListener(event: 'close', listener: () => void): this;
244+
prependListener(event: 'drain', listener: () => void): this;
245+
prependListener(event: 'error', listener: (err: Error) => void): this;
246+
prependListener(event: 'finish', listener: () => void): this;
247+
prependListener(event: 'pipe', listener: (src: stream.Readable) => void): this;
248+
prependListener(event: 'unpipe', listener: (src: stream.Readable) => void): this;
249+
prependListener(event: string | symbol, listener: (...args: any[]) => void): this;
250+
251+
prependOnceListener(event: 'abort', listener: () => void): this;
252+
prependOnceListener(event: 'connect', listener: (response: IncomingMessage, socket: Socket, head: Buffer) => void): this;
253+
prependOnceListener(event: 'continue', listener: () => void): this;
254+
prependOnceListener(event: 'information', listener: (info: InformationEvent) => void): this;
255+
prependOnceListener(event: 'response', listener: (response: IncomingMessage) => void): this;
256+
prependOnceListener(event: 'socket', listener: (socket: Socket) => void): this;
257+
prependOnceListener(event: 'timeout', listener: () => void): this;
258+
prependOnceListener(event: 'upgrade', listener: (response: IncomingMessage, socket: Socket, head: Buffer) => void): this;
259+
prependOnceListener(event: 'close', listener: () => void): this;
260+
prependOnceListener(event: 'drain', listener: () => void): this;
261+
prependOnceListener(event: 'error', listener: (err: Error) => void): this;
262+
prependOnceListener(event: 'finish', listener: () => void): this;
263+
prependOnceListener(event: 'pipe', listener: (src: stream.Readable) => void): this;
264+
prependOnceListener(event: 'unpipe', listener: (src: stream.Readable) => void): this;
265+
prependOnceListener(event: string | symbol, listener: (...args: any[]) => void): this;
175266
}
176267

177268
class IncomingMessage extends stream.Readable {

‎types/node/index.d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Type definitions for non-npm package Node.js 12.6
1+
// Type definitions for non-npm package Node.js 12.7
22
// Project: http://nodejs.org/
33
// Definitions by: Microsoft TypeScript <https://github.com/Microsoft>
44
// DefinitelyTyped <https://github.com/DefinitelyTyped>

0 commit comments

Comments
 (0)