-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing and Feedback Wanted! #3
Comments
Hey, Garrick, I liked this package and the themes it offered! Thank you for that. The I hope this helps you. |
Hi @kguidonimartins, thanks for the feedback! Did you push enter after k or q? I realize now the prompt makes it seem like you only need to press k, but you have to hit k and then Enter for your selection to be registered. If this was the issue, I'll clean up the prompt text. |
Hi Garrick, that's it! The prompt makes it seem like you only need to hit one letter key. Besides, when I run the |
Great! And you're right, you can just exit the function to keep the current theme but I wanted to reduce surprises 😄 Thanks again! |
Restore current theme on exit if user cycles through all themes Prompt after all themes, including last
Hi Garrick, I am living on the bleeding edge with RStudio and using Version 1.3.548 rsthemes themes do not work currently. Just to let you know that there might be some breaking changes in v1.3 (Loving the auto-schedule feature! I've wanted this for so long already 👍 still switching manually daily since I was too lazy to create my own `rstudioapi´ bindings yet) |
Hi @pat-s – that's odd. I just tested with 1.3.563 in a Docker container that I use for testing and it seems to be working as expected. Can you poke around a bit more in your setup or provide a few more details? Does installing/uninstalling help? |
I am on macOS. v1.3.566 still has this problem. I tested a few dailies.
Somewhere in between must be a breaking change, at least on macOS. |
@pat-s thanks for your help on this one! The directory for RStudio's config information changed to |
Hi Garrick, {rsthemes} is really cool. Thanks for all the work you put into it. My go-to themes are the Solarized (both Dark and Light). I really like your changes to those. There's one small thing I miss - the comments. In the RStudio interpretation they are italicized and the code is a slightly lighter shade of grey. I don't know what your take is, but for me the contrast in the RStudio version reads a bit better. |
#3 (comment) * Make comments italicized * Fix colors of comments in solarized dark * Adjust colors of invisible characters
Thanks @dragosmg, that's a great suggestion! I updated the color of code comments in the solarized rsthemes to make sure they match the colors suggested by the palette creator and I italicized the comments. |
@gadenbuie thanks a lot. Wow, that was quick! |
Thank you so much for this package. Absolutely love it. The themes look great, and the toggle and auto add-ins are real time savers. If you want some suggestions on how to improve the dark themes (particularly the One Dark {rstheme}), it would be nice if you could include the dynamic darkening of plots and markdown feature from the Mojave Dark theme. |
Did they change it back to Awesome package! 😄 |
On Windows its Soon v1.3 will be the default but maybe @gadenbuie can include a condition anyways? :) |
Thanks @leonawicz and @pat-s ... rather than guess the correct directory, I went back to using the |
Hello,
|
Try removing/commenting calls to {rsthemes} in |
Great - many thanks. All good now. |
Looks like your Rtools install maybe corrupted. Remove all installations (especially old ones), reinstall Rtools and try again. |
Tested Rstudio preview 1.4 and worked flawlessly |
I'm noticing the same issues with Monokai theme as @LDalby . I'm thinking it's an rstudio default that the menus colors only have a light versus dark color and are not editable by themes? But I hope I'm wrong. The same thing appears in the files folder - no matter what theme I choose, the files pane has the same purple links. Again, I assume these are not customizable but I'd love to be wrong! |
Thank you for this awesome package! I use it on my job, in my home computer, everywhere even in the server where I cannot use devtools I copied your rstheme to use directly! I use on arch, manjaro, windows 10, windows 11 and windows server. The only difficulty is trying to find things on code, the highlight color is too similar to be seen easily. I'm using the night-owl theme in all machines. [edit] I added a theme with only the selection and name changed to a new color more visible. |
I'd love feedback and help testing the themes! Please leave a comment here if you try out the themes and find any issues or have any suggestions.
Here's how to install and use the themes.
And, finally, if you want to uninstall the themes
The text was updated successfully, but these errors were encountered: