ICU 74.1 sources included

Author: gagolews

.devel/icu_upgrade_patches-74.md

@@ -1,6 +1,6 @@
 # ICU 74 Patching Info
 
-## Diffs for ICU69 (Patches applied in due course)
+## Diffs for ICU 69 (Patches applied in due course)
 
 ```bash
 COMMIT_ORIGINAL=bbbf25bbe6e1aa198389dd08636a3360b5788213
@@ -40,26 +40,47 @@ done
 ```
 
 
-## TODO: Download ICU
+## Fetch ICU4C
 
-https://github.com/unicode-org/icu/releases/tag/release-74-1
+1. Download https://github.com/unicode-org/icu/releases/download/release-74-1/icu4c-74_1-src.zip
 
-https://github.com/unicode-org/icu/releases/download/release-74-1/icu4c-74_1-src.zip
+2. From the extracted archive, copy source/common, i18n, stubdata to ./src/icu74
 
-icudt is available for download from:
+3. Move ./src/icu74/i18n/unicode and ./src/icu74/common/unicode to ./src/icu74/unicode (together)
 
-https://github.com/unicode-org/icu/releases/download/release-74-1/icu4c-74_1-data-bin-b.zip
-https://github.com/unicode-org/icu/releases/download/release-74-1/icu4c-74_1-data-bin-l.zip
+4. Update ./LICENSE
 
-Compress icudt-l with xz, include in the source bundle
+5. Create ./src/icu74/LICENSE
 
-icudt-b should be downloaded on demand during install
+7. Execute from ./src/icu74/:
 
+    ```bash
+    rm -f **/*.rc **/*.vcproj **/*.vcxproj **/*filters **/BUILD* **/Makefile.in
+    mv i18n/sources.txt ../icu74_i18n_cpp.txt
+    mv common/sources.txt ../icu74_common_cpp.txt
+    mv stubdata/sources.txt ../icu74_stubdata_cpp.txt
+    ```
 
-! Use `#ifdef U_STRINGI_PATCHES`
 
+# ICU data
 
-## TODO: Patch ICU
+Destination: ./src/icu74/data
+
+```{bash}
+for endian in l b; do
+    wget -nc https://github.com/unicode-org/icu/releases/download/release-74-1/icu4c-74_1-data-bin-${endian}.zip
+    unzip -o icu4c-74_1-data-bin-${endian}.zip
+    sha256sum -b icudt74${endian}.dat > icudt74${endian}.dat.sha256sum
+    xz -z -e -9 icudt74${endian}.dat
+done
+```
+
+Only include icudt74l.dat.xz in the source bundle.
+icudt74b.dat should be downloaded on demand during install.
 
 
-? use sources.txt.
+
+
+## TODO: Patch ICU
+
+! Use `#ifdef U_STRINGI_PATCHES`

CODE_OF_CONDUCT.md

@@ -6,6 +6,6 @@ act of charity to make this world an (even) better place.
 It will most likely pass unnoticed, but if you happen to find it useful,
 informative, amusing, or stimulating, we're happy for you.
 
-All nice contributions/comments/remarks are welcome.
+All quality contributions/comments/remarks are welcome.
 
 Please spread the news about this package.

INSTALL

@@ -2,47 +2,43 @@
 
 In most cases, installing *stringi* is as simple as calling:
 
-
 ```r
 install.packages("stringi")
 ```
 
-
 However, due to the overwhelming complexity of the ICU4C library,
-upon which *stringi* is based, and the colourful diversity of operating systems,
-their flavours, and particular setups, some users may still experience
-a few issues that hopefully can be resolved with the help of this short manual.
+upon which *stringi* is based, and the colourful diversity of environments
+it operates on, you might still experience a few issues.
+Hopefully, they can be resolved with the help of this short manual.
 
-Also, some build tweaks are possible.
+Below we also describe some available build process tweaks.
 
 
 ## ICU4C
 
 The stringi package depends on the ICU4C >= 61 library.
 
-
-If we install the package from sources and either:
+If we install the package from sources and one of the following is true:
 
 * this requirement is not met (check out <https://icu.unicode.org/download>,
-   the `libicu-devel` rpm on Fedora/CentOS/OpenSUSE,
-   `libicu-dev` on Ubuntu/Debian, etc.),
+    the `libicu-devel` package on Fedora/CentOS/OpenSUSE,
+    `libicu-dev` on Ubuntu/Debian, etc.), or
 
 * `pkg-config` fails to find appropriate build settings
-   for ICU-based projects, or
+    for ICU-based projects, or
 
 * `R CMD INSTALL` is called with the `--configure-args='--disable-pkg-config'`
-    argument, or environment variable `STRINGI_DISABLE_PKG_CONFIG` is
-    set to non-zero or
+    argument, or the `STRINGI_DISABLE_PKG_CONFIG` environment variable
+    is set to non-zero or
     `install.packages("stringi", configure.args="--disable-pkg-config")`
     is executed,
 
-then ICU will be built together with stringi.
-A custom subset of ICU4C 74.1 is shipped with the package.
-
+then ICU will be built together with stringi based on the customised
+ICU4C 74.1 source bundle that is shipped with the package.
 
-> To get the most out of stringi, you are strongly encouraged to rely on our
-> ICU4C package bundle. This ensures maximum portability across all platforms
-> (Windows and macOS users by default fetch the pre-compiled binaries
+> Actually, to get the most out of stringi, you are strongly encouraged to rely
+> on our ICU4C bundle. This ensures maximum portability across all platforms
+> (Windows and macOS users fetch the pre-compiled binaries
 > from CRAN built precisely this way).