Reloaded - Gtk3 migration

[d-j-a-y]

https://github.com/d-j-a-y/veejay/commits/djay_gtk3

Reloaded specific

• gtkcurve --> new widget base : https://github.com/draekko-rand/Gtk3Curve

General Stuff
Preparation in GTK+ 2.x

Do not include individual headers
Do not use deprecated symbols
Use accessor functions instead of direct access
Replace GDK_ with GDK_KEY_
Use GIO for launching applications
Use cairo for drawing

Changes that need to be done at the time of the switch

Replace size_request by get_preferred_width/height
Replace GdkRegion by cairo_region_t
Replace GdkPixmap by cairo surfaces
Replace GdkColormap by GdkVisual
GdkDrawable is gone
Event filtering
Backend-specific code
GtkPlug and GtkSocket
The GtkWidget::draw signal
GtkProgressBar orientation
Check your expand and fill flags
Scrolling changes
GtkObject is gone
GtkEntryCompletion signal parameters
Resize grips
Prevent mixed linkage <--- see #163 (comment)
Install GTK+ modules in the right place

https://developer.gnome.org/gtk3/stable/gtk-migrating-2-to-3.html
https://developer.gnome.org/gtk3/stable/ch26s02.html
https://wiki.ubuntu.com/Lubuntu/Developers/GTK3Migration

After all .... TESTS!

TODO Before release

* Xorg high cpu! For instance, the program might be making resource-intensive xlib calls in a tight loop https://wiki.ubuntu.com/X/Troubleshooting/HighCPU ---- FIX issue exemple Fixed by cfa0a2e . See also #163 (comment)

• ./Makefile.am --> review EXTRA_DIST
• Fix Gtk-3 Minor version according api used (actually 3.0 but couldbe 3.10)
  * gtktimeselection / event_motion
  * multitrack / time line (horizontal slider) ... broken ? fixed by aacf57a
  * multitrack / opacity - chainfade (vertical n2 slider) ... broken ? fixed by bb13efe
  * fix vbox619 (stream/camera controls) scrolling fix by e60da41
  * fx and generator param's sliders don't catch mouse 3th btn roll fixed by fa890bd
  * fix feedback checkbox align fix by e60da41
  * scale value is not displayed full : change fx param widget container order : [ fx parameter value ] top hbox [ fx param description + fx param slider ] bottom vbox not ui issue, value is own by gtkscale, issue can be solved using a label out of gtkscale.
• where the menu s gone ?
• -a option broken
• can't select codec when recording sample/stream (panel "Sample X" ---> "Recording to Disk" ---> drop down list "Codec")

minor

• close veejay before reloaded --> can't close veejay_connection
• close confirm dialog : [echap] should close dialog box not reloaded (self assign @d-j-a-y )
• src/Makefile.am --> -lgmodule-2.0 should goto config.am
• Purge/remove files not used stuff from reloaded and veejay
  ** gtkcolorsel (picker for ex) ... palette and other ?
  ** remove gtkhsv files
  ** Purge veejay config files
• config.am : remove GLADE check (add GtkBuilder ?)
• remove or update GTK_CHECK_VERSION related (ex vj-api.c)
• Update veejay/reloaded dependencies (doc side)
• reloaded as GtkApplication ?
• Check if all gtk_*_new () calls have g_clear_object or g_object_unref counter part

TODO After release

• Greetings to draekko-rand for Gtk3Curve

• image in menu : gtkmenuitem + packing for image in menu, imagemenuitem deprecated from 3.10

  Add a status bar to connexion dialog ?
  fix gtkdialog ui def :      <child internal-child="vbox">    and     <child internal-child="action_area">
  

[d-j-a-y]

Prevent mixed linkage

Gtk-ERROR **: GTK+ 2.x symbols detected. Using GTK+ 2.x and GTK+ 3 in the same process is not supported

To determine how the mix is done :

for i in `ldd /usr/local/bin/reloaded | awk '{print $3}'` ; do \
        if [[ `ldd $i | grep gtk` ]] ; then \
           echo -e "$i \n `ldd $i | grep gtk` \n" ; \
        fi ; done

(from milan / https://mail.gnome.org/archives/evolution-hackers/2011-February/msg00003.html )

[d-j-a-y]

Glad to share the reloaded gtk3 first run :-)

At least it's running, and basic stuff is working ...

[game-stop]

Hey that looks nice :) Still, its a lot of work to tweak the UI :D Some buttons fell off the screen :P See you!

…

On Fri, Sep 7, 2018 at 2:55 PM d-j-a-y ***@***.***> wrote: Glad to share the reloaded gtk3 first run :-) [image: reloaded-gtk3-firstrun] <https://user-images.githubusercontent.com/2943058/45220155-88dbe980-b2ad-11e8-87ba-ed18017dd7ea.jpg> At least it's running, and basic stuff is working ... — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#163 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHfPfHU2SxzK7A0k7ONOJp-9k1lBa-W9ks5uYmzagaJpZM4WVA-q> .

[d-j-a-y]

after a bit of css ....finally ! :-)

[d-j-a-y]

now with a bit of gtk3 theming :-O

pink + green buttons come from tweaks on "reloaded.css"

[game-stop]

Except for the purple it looks good!
The feedback checkbox in the top looks a bit odd
Do the widgets without a label have a tooltip ?
There are a few other windows in reloaded, have you GTK3'd them as well ? Would be nice if you can show those too!

[d-j-a-y]

feedback

+todolist

tooltips

yep, expect those who did't had ... ;-)

other windows gtk3

yep, but ... still ... the menu is missing and so ... can't test them.

The curve widget look nice, but maybe will need some hack about rounding because, since ever?, the curve has always had trouble with that (hit [ok] several time, the curve will tend to 0 --- #AnotherIssue --- )

[d-j-a-y]

@C0ntrol
Theming by rc is broken.
Gtk3 already offers to use other theme at runtime for particular app with the environment variable GTK_THEME

Do you think it's necessary to keep the user defined gui definition feature ? (gtk3 fashion is css)

[game-stop]

No, let's not go fix that. Back then, it was more of a hack anyway. Please remove all that has to do with it

[d-j-a-y]

finally ... got (bits of) the menu back ....

after unsuccessful try to declare it at runtime ... come back to ressources with gtkmenubar/ gtkmenu / gtkmenuitem /... definitions ... (where it was GtkUIManager / GtkActionGroup / GtkAction ...)

[d-j-a-y]

Menus are back !

https://github.com/d-j-a-y/veejay/tree/djay_gtk3

[game-stop]

Great! Is it ready to be merged ?

[d-j-a-y]

Hummm .... why not ???

some corners to polish ... but should be usable .... (reloaded -a , still broken for example)

But , please can you stress test it ?.... during let's say one week before merging ?

In fact , i really suspect performance issues !

[cpu] [mem]
 65,9 11,2  48:20.32 veejay                       
 42,6  3,0  11:06.20 Xorg                         
 28,5  2,4   0:18.61 reloaded 

and without reloaded Xorg consume quite nothing from cpu....

---

Also, could be a good moment to publicity at this incredible and unique piece of floss code. . . what do you think ? Publish .deb / rpm .... ? submit to packager .... ? maybe too much ... at the same time ...