Skip to content

Conversation

@NotTheEvilOne
Copy link
Contributor

@NotTheEvilOne NotTheEvilOne commented Nov 6, 2025

What this PR does / why we need it:
This PR changes the GardenLinux canonical name behavior and features parser to only accept one platform. It further enhances S3 artifact handling to respect more values of *.release files.

Which issue(s) this PR fixes:
Related gardenlinux/gardenlinux#3816
Supersedes #249
Fixes gardenlinux/gardenlinux#3824
Fixes #244

@NotTheEvilOne NotTheEvilOne requested review from a team, fwilhe and nkraetzschmar November 6, 2025 15:48
@NotTheEvilOne NotTheEvilOne self-assigned this Nov 6, 2025
@NotTheEvilOne NotTheEvilOne force-pushed the feature/enforce-one-platform-policy branch from 627b866 to c9cc60d Compare November 6, 2025 15:49
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 79.10448% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.20%. Comparing base (d64300c) to head (68a68ba).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/gardenlinux/features/__main__.py 56.25% 7 Missing ⚠️
src/gardenlinux/features/cname.py 62.50% 6 Missing ⚠️
src/gardenlinux/s3/s3_artifacts.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
+ Coverage   90.63%   91.20%   +0.57%     
==========================================
  Files          42       42              
  Lines        2008     2025      +17     
==========================================
+ Hits         1820     1847      +27     
+ Misses        188      178      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NotTheEvilOne NotTheEvilOne force-pushed the feature/enforce-one-platform-policy branch 2 times, most recently from b131b16 to 16509ef Compare November 7, 2025 11:52
@NotTheEvilOne NotTheEvilOne changed the title Enforce one platform policy for GardenLinux canonical names Enforce one platform policy for GardenLinux canonical names and enhance S3 artifact handling Nov 7, 2025
@NotTheEvilOne NotTheEvilOne force-pushed the feature/enforce-one-platform-policy branch 2 times, most recently from 40b5f95 to e0f8e96 Compare November 7, 2025 12:16
@NotTheEvilOne NotTheEvilOne force-pushed the feature/enforce-one-platform-policy branch from e0f8e96 to e73655f Compare November 7, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish breaks on feature drift between rel and main branches gl-features-parse incorrectly sorts features

4 participants