Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more customizable 'user' options for the admin to be able to control what they can and can't do. #412

Open
pjghangouts opened this issue Sep 2, 2024 · 5 comments
Labels
enhancement New feature or request security Security enhancement

Comments

@pjghangouts
Copy link

I'm going to be using your software to run a monthly community driven retro game competitions, but I'd like the option to be able to control whether the user can download the roms, use the 'cheats' etc, so I'm asking if there can be more control from an Admin standpoint what you can give to a user after you've set them up. Maybe the basic could just be a 'Play Game' option, nothing else.

@michael-j-green
Copy link
Member

Happy to look into something like this for after v1.8.0 is released, as it's going to need alot of thought to flesh out (plus some minor to major surgery to implement). Do you have an idea of what permissions/features you'd like to control access to (aside from what you've noted above)?

Note that in order to play a game, a user must be able to download that ROM file since the ROM is executed in the browser. At best I can hide the link to download the file itself, but it wouldn't stop someone from connecting via the API or if they knew the link to the file (which they could get by hovering their mouse over the Launch button).

@gaseous-project gaseous-project deleted a comment Sep 2, 2024
@michael-j-green
Copy link
Member

michael-j-green commented Sep 2, 2024

Spotted that too (should have checked before I commented :D )

I've edited your reply to redact the download link so no one else downloads the malware.

@pjghangouts
Copy link
Author

pjghangouts commented Sep 2, 2024

As for your

Happy to look into something like this for after v1.8.0 is released, as it's going to need alot of thought to flesh out (plus some minor to major surgery to implement). Do you have an idea of what permissions/features you'd like to control access to (aside from what you've noted above)?

Note that in order to play a game, a user must be able to download that ROM file since the ROM is executed in the browser. At best I can hide the link to download the file itself, but it wouldn't stop someone from connecting via the API or if they knew the link to the file (which they could get by hovering their mouse over the Launch button).

I'll have a deeper thought and come back to you about what I think for any extra stuff, totally get the 'download' into the browser, but most of my people would be more of a 'quarter - player 1' type of people, with options to download stuff, etc, could confuse them. Happy you are open to suggestions.

@michael-j-green michael-j-green added security Security enhancement enhancement New feature or request labels Sep 2, 2024
@pjghangouts
Copy link
Author

Spotted that too (should have checked before I commented :D )

I've edited your reply to redact the download link so no one else downloads the malware.

Yeah, should have done the same myself. sorry! and I blocked and reported also.

@michael-j-green
Copy link
Member

As for your

Happy to look into something like this for after v1.8.0 is released, as it's going to need alot of thought to flesh out (plus some minor to major surgery to implement). Do you have an idea of what permissions/features you'd like to control access to (aside from what you've noted above)?
Note that in order to play a game, a user must be able to download that ROM file since the ROM is executed in the browser. At best I can hide the link to download the file itself, but it wouldn't stop someone from connecting via the API or if they knew the link to the file (which they could get by hovering their mouse over the Launch button).

I'll have a deeper thought and come back to you about what I think for any extra stuff, totally get the 'download' into the browser, but most of my people would be more of a 'quarter - player 1' type of people, with options to download stuff, etc, could confuse them. Happy you are open to suggestions.

Totally makes sense. Some of these permissions would be server side, while others would simply be hiding features in the UI.

v1.8.0 has had a UI revamp, so these permission changes will need to happen after that's released - so we have plenty of time to work out a permissions model (check the milestones for v.1.8.0 for my progress so far).

Spotted that too (should have checked before I commented :D )
I've edited your reply to redact the download link so no one else downloads the malware.

Yeah, should have done the same myself. sorry! and I blocked and reported also.

All good :)

I feel like I've brought my day job home banning that guy :D

@gaseous-project gaseous-project deleted a comment Sep 2, 2024
@github-staff github-staff deleted a comment from pjghangouts Sep 4, 2024
@github-staff github-staff deleted a comment from michael-j-green Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request security Security enhancement
Projects
None yet
Development

No branches or pull requests

2 participants