Skip to content

Commit 384e2f2

Browse files
committed
2.4.1.4 - Removed width check on SelectBitmap in FormRegionSelectWithMouse.
1 parent d5c5992 commit 384e2f2

File tree

7 files changed

+19
-22
lines changed

7 files changed

+19
-22
lines changed

AutoScreenCaptureSetup/AutoScreenCaptureSetup.vdproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -233,15 +233,15 @@
233233
{
234234
"Name" = "8:Microsoft Visual Studio"
235235
"ProductName" = "8:Auto Screen Capture"
236-
"ProductCode" = "8:{A39FED41-4E02-450A-9148-96090F1677F9}"
237-
"PackageCode" = "8:{6006D0E9-7E33-4012-8174-10FB01284BD4}"
236+
"ProductCode" = "8:{E34FF3E7-FC0B-457F-B66D-1D5CFA2B8494}"
237+
"PackageCode" = "8:{D9813AB0-59C8-4FC2-8207-2E8AF204A9FB}"
238238
"UpgradeCode" = "8:{6B29B7BC-0101-4495-B28C-26B6D3CDCC02}"
239239
"AspNetVersion" = "8:4.0.30319.0"
240240
"RestartWWWService" = "11:FALSE"
241241
"RemovePreviousVersions" = "11:TRUE"
242242
"DetectNewerInstalledVersion" = "11:TRUE"
243243
"InstallAllUsers" = "11:FALSE"
244-
"ProductVersion" = "8:2.4.13"
244+
"ProductVersion" = "8:2.4.14"
245245
"Manufacturer" = "8:Gavin Kendall"
246246
"ARPHELPTELEPHONE" = "8:"
247247
"ARPHELPLINK" = "8:https://sourceforge.net/p/autoscreen/tickets/"

Properties/AssemblyInfo.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,6 @@
3232
// You can specify all the values or you can default the Build and Revision Numbers
3333
// by using the '*' as shown below:
3434
// [assembly: AssemblyVersion("1.0.*")]
35-
[assembly: AssemblyVersion("2.4.1.3")]
36-
[assembly: AssemblyFileVersion("2.4.1.3")]
35+
[assembly: AssemblyVersion("2.4.1.4")]
36+
[assembly: AssemblyFileVersion("2.4.1.4")]
3737
[assembly: NeutralResourcesLanguageAttribute("en-CA")]

app.manifest

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<assemblyIdentity
44
type="win32"
55
name="GavinKendall.AutoScreenCapture"
6-
version="2.4.1.3"/>
6+
version="2.4.1.4"/>
77
<asmv3:application>
88
<asmv3:windowsSettings xmlns="http://schemas.microsoft.com/SMI/2005/WindowsSettings">
99
<dpiAware>True/PM</dpiAware>

changelog.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
Auto Screen Capture by Gavin Kendall
22

33

4+
2.4.1.4 Removed width check on SelectBitmap in FormRegionSelectWithMouse.
45
2.4.1.3 Small corrections made to Region Select methods after mouse selection has completed. (February 9, 2021)
56
2.4.1.2 Reverted changes that were implemented in 2.4.1.1 essentially making this version the same as 2.4.1.0
67
2.4.1.1 !!! DO NOT USE THIS VERSION !!! These were changes to the GetScreenBitmap method which were absolutely terrible and should never have been implemented for dual-screen displays.

interface/about/FormAbout.Designer.cs

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

interface/region_select/FormRegionSelectWithMouse.cs

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -233,25 +233,20 @@ private void pictureBoxMouseCanvas_MouseUp(object sender, MouseEventArgs e)
233233
/// <returns>Returns a bitmap image based on X, Y, Width, and Height.</returns>
234234
private Bitmap SelectBitmap()
235235
{
236-
if (_selectWidth > 0)
237-
{
238-
Rectangle rect = new Rectangle(_selectX, _selectY, _selectWidth, _selectHeight);
239-
Bitmap bitmapDestination = new Bitmap(pictureBoxMouseCanvas.Image, pictureBoxMouseCanvas.Width, pictureBoxMouseCanvas.Height);
236+
Rectangle rect = new Rectangle(_selectX, _selectY, _selectWidth, _selectHeight);
237+
Bitmap bitmapDestination = new Bitmap(pictureBoxMouseCanvas.Image, pictureBoxMouseCanvas.Width, pictureBoxMouseCanvas.Height);
240238

241-
Bitmap bitmapSource = new Bitmap(_selectWidth, _selectHeight);
239+
Bitmap bitmapSource = new Bitmap(_selectWidth, _selectHeight);
242240

243-
using (Graphics g = Graphics.FromImage(bitmapSource))
244-
{
245-
g.InterpolationMode = InterpolationMode.HighQualityBicubic;
246-
g.PixelOffsetMode = PixelOffsetMode.HighQuality;
247-
g.CompositingQuality = CompositingQuality.HighQuality;
248-
g.DrawImage(bitmapDestination, Left, Top, rect, GraphicsUnit.Pixel);
249-
}
250-
251-
return bitmapSource;
241+
using (Graphics g = Graphics.FromImage(bitmapSource))
242+
{
243+
g.InterpolationMode = InterpolationMode.HighQualityBicubic;
244+
g.PixelOffsetMode = PixelOffsetMode.HighQuality;
245+
g.CompositingQuality = CompositingQuality.HighQuality;
246+
g.DrawImage(bitmapDestination, Left, Top, rect, GraphicsUnit.Pixel);
252247
}
253248

254-
return null;
249+
return bitmapSource;
255250
}
256251

257252
/// <summary>

settings/Settings.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,7 @@ public void Load(FileSystem fileSystem)
261261
_versionCollection.Add(new Version(CODENAME_BLADE, "2.4.1.0")); // Region Select fix.
262262
_versionCollection.Add(new Version(CODENAME_BLADE, "2.4.1.1")); // GetScreenBitmap fix. (but it actually made it worse for a dual-display setup)
263263
_versionCollection.Add(new Version(CODENAME_BLADE, "2.4.1.2")); // Reverted changes to GetScreenBitmap method in ScreenCapture.
264+
_versionCollection.Add(new Version(CODENAME_BLADE, "2.4.1.3")); // Small corrections made to Region Select methods after mouse selection has completed.
264265

265266
Application = new SettingCollection()
266267
{

0 commit comments

Comments
 (0)