Skip to content

Remove SupressWarning.hh from this repo #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
scpeters opened this issue May 3, 2023 · 5 comments
Open

Remove SupressWarning.hh from this repo #348

scpeters opened this issue May 3, 2023 · 5 comments
Labels
Breaking change Breaks API, ABI or behavior. Must target unstable version. enhancement New feature or request 🪵 jetty Gazebo Jetty

Comments

@scpeters
Copy link
Member

scpeters commented May 3, 2023

Desired behavior

The gz/utilities/SuppressWarning.hh header file here in gz-cmake seems redundant with the gz/utils/SuppressWarning.hh from gz-utils. I think we should deprecate or remove the one hosted by gz-cmake.

Alternatives considered

Implementation suggestion

Additional context
@scpeters scpeters added enhancement New feature or request 🎵 harmonic Gazebo Harmonic labels May 3, 2023
@azeey
Copy link
Contributor

azeey commented May 3, 2023

+1 for deprecating it in main.

@scpeters scpeters mentioned this issue Jul 18, 2023
Merged
9 tasks
@azeey azeey moved this to To do in Core development Jul 24, 2023
@scpeters
Copy link
Member Author

deprecated in #367

@github-project-automation github-project-automation bot moved this from To do to Done in Core development Jul 27, 2023
@scpeters
Copy link
Member Author

scpeters commented Nov 4, 2023

close when it has been removed

@scpeters scpeters reopened this Nov 4, 2023
@github-project-automation github-project-automation bot moved this from Done to Inbox in Core development Nov 4, 2023
@scpeters scpeters changed the title Deprecate / remove SupressWarning.hh from this repo Remove SupressWarning.hh from this repo Jan 24, 2024
@scpeters scpeters added Breaking change Breaks API, ABI or behavior. Must target unstable version. and removed 🎵 harmonic Gazebo Harmonic labels Jun 21, 2024
@scpeters scpeters added the 🪵 jetty Gazebo Jetty label May 1, 2025
@scpeters
Copy link
Member Author

scpeters commented May 1, 2025

let's remove these headers in gz-cmake5

@scpeters
Copy link
Member Author

scpeters commented May 1, 2025

making a different cleanup in a related area of code in #498. will try removing the entire include folder and utilities targets once that is merged forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking change Breaks API, ABI or behavior. Must target unstable version. enhancement New feature or request 🪵 jetty Gazebo Jetty
Projects
Core development
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@azeey @scpeters