Exporting an `ee.ImageCollection`

[fitoprincipe]

this Issue made me realize that the function to export an image collection has not been implemented in the same way as the older version of this package. The main difference, that I'd like to see "restored", is the ability to create the file names using the image properties (namePattern argument).

geetools/geetools/batch/imagecollection.py

Lines 9 to 11 in 918abab

	def toDrive(collection, folder, namePattern='{id}', scale=30,
	dataType="float", region=None, datePattern=None,
	extra=None, verbose=False, **kwargs):

Also, I think that this line

geetools/geetools/ee_export.py

Line 81 in 14fdc79

loc_id = locImage.get(index_property).getInfo()

forces the collection to be computed as a list, due to

geetools/geetools/ee_export.py

Line 76 in 14fdc79

imageList = imagecollection.toList(nb_images)

if the collection had an intense computation it might fail due to memory issues. Instead, I propose to loop over the system:index property, which by definition is always unique (this was not the way it was coded in the previous version)

[12rambau]

Yeah sorry i was super tired of refactoring when I did batch module so I started being lazy with some mechanisms. I'll reimplement the namePattern one ASAP.

[12rambau]

if the collection had an intense computation it might fail due to memory issues. Instead, I propose to loop over the system:index property, which by definition is always unique (this was not the way it was coded in the previous version)

Do you mean extracting the system:index with a aggregate array and then use it as a filter in the loop ?

[fitoprincipe]

Yeah sorry i was super tired of refactoring when I did batch module so I started being lazy with some mechanisms. I'll reimplement the namePattern one ASAP.

it's not urgent, not need to do it ASAP. I could also do it if you want.

[fitoprincipe]

if the collection had an intense computation it might fail due to memory issues. Instead, I propose to loop over the system:index property, which by definition is always unique (this was not the way it was coded in the previous version)

Do you mean extracting the system:index with a aggregate array and then use it as a filter in the loop ?

exactly 👍