Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new version please πŸ™ #312

Closed
dustinfarris opened this issue Apr 7, 2022 · 14 comments
Closed

new version please πŸ™ #312

dustinfarris opened this issue Apr 7, 2022 · 14 comments

Comments

@dustinfarris
Copy link

need the dropped hut dependency β€”Β can peg to the latest commit but would prefer a new release if it makes sense. thanks!

@cw789
Copy link
Contributor

cw789 commented Apr 7, 2022

I also think this would be necessary with the release of Elixir v1.14 as it seems rebar2 support is dropped in Mix.
Anyway I don't know why hut is build with rebar2 within Mix.

@arjan
Copy link
Collaborator

arjan commented Apr 7, 2022

@mworrell @seriyps I can release a new version tomorrow, wdyt? A lot has been changed, last release was over a year ago.. not sure if there are any backward incompatibilities though.

@mworrell
Copy link
Collaborator

mworrell commented Apr 8, 2022

@arjan I am for a release! A lot has been done.

@arjan
Copy link
Collaborator

arjan commented Apr 8, 2022

Okay waiting for @seriyps for feedback on #311 otherwise i'll release without it end of the day

@ak-14
Copy link

ak-14 commented Apr 11, 2022

@arjan any update on this?

@cw789
Copy link
Contributor

cw789 commented Apr 12, 2022

Let us not rush. Elixir v1.13.4 do just warn of the deprecation of rebar2.
The hard deprecation will follow in v1.14, which is still some week away (in my opinion).

So to all us Elixir users. I think everything should still work. It's just a red warning. πŸ˜Άβ€πŸŒ«οΈ

@arjan
Copy link
Collaborator

arjan commented Apr 13, 2022

I've tagged 1.2.0 now and published to hex!

@arjan
Copy link
Collaborator

arjan commented Apr 13, 2022

Docs also built and published now, and github release page updated.

@arjan arjan closed this as completed Apr 13, 2022
@cw789
Copy link
Contributor

cw789 commented Apr 13, 2022

Thanks a lot for your work.

@cw789
Copy link
Contributor

cw789 commented Apr 13, 2022

One thing I've found. ExDoc source_ref seems to expect a tag like v1.2.0.
So either tag it as that or we need to manually set the source_ref in the rebar.config.

But this just means the source links within the docs do not work.

@arjan
Copy link
Collaborator

arjan commented Apr 13, 2022

Hmm interesting.. where do you see this issue?

@cw789
Copy link
Contributor

cw789 commented Apr 13, 2022

image

@arjan
Copy link
Collaborator

arjan commented Apr 13, 2022

Okay so I traced the issue, the problem is that the rebar3_ex_doc plugin makes this assumption, here

@arjan
Copy link
Collaborator

arjan commented Apr 13, 2022

was already reported actually jelly-beam/rebar3_ex_doc#18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants