list + better error message

Author: genintho

src/parser/class.js

@@ -253,23 +253,26 @@ module.exports = {
         let name = null;
         let value = null;
 
-        if (
-          this.version >= 803 &&
-          type &&
-          (type.kind === "typereference" || type.kind === "uniontype")
-        ) {
+        if (type && type.kind === "name") {
+          constName = this.node("identifier");
+          constName = constName(type.name);
+          type = null;
+          value = this.next().read_expr();
+        } else {
           constName = this.node("identifier");
           name = this.text();
           constName = constName(name);
           this.next();
           this.expect("=");
           value = this.next().read_expr();
-        } else if (type && type.kind === "name") {
-          constName = this.node("identifier");
-          constName = constName(type.name);
-          type = null;
-          value = this.next().read_expr();
         }
+
+        if (this.version < 803 && type !== null) {
+          this.raiseError(
+            "Parse Error: Typed Class Constants requires PHP 8.3+",
+          );
+        }
+
         return result(constName, value, nullable, type);
       },
       ",",

test/snapshot/__snapshots__/class.test.js.snap

@@ -1321,7 +1321,7 @@ Program {
       "attrGroups": [],
       "body": [
         ClassConstant {
-          "attrGroups": [],
+          "attrGroups": undefined,
           "constants": [
             Constant {
               "kind": "constant",
@@ -1340,7 +1340,7 @@ Program {
           ],
           "final": false,
           "kind": "classconstant",
-          "nullable": false,
+          "nullable": [],
           "type": null,
           "visibility": "",
         },
@@ -1433,7 +1433,7 @@ Program {
           "visibility": "public",
         },
         ClassConstant {
-          "attrGroups": [],
+          "attrGroups": undefined,
           "constants": [
             Constant {
               "kind": "constant",
@@ -1452,7 +1452,7 @@ Program {
           ],
           "final": false,
           "kind": "classconstant",
-          "nullable": false,
+          "nullable": [],
           "type": null,
           "visibility": "",
         },

test/snapshot/classconstant.test.js

@@ -63,4 +63,15 @@ describe("classconstant", () => {
       ),
     ).toThrowErrorMatchingSnapshot();
   });
+
+  it("accept the constant name 'list'", () => {
+    expect(
+      parser.parseEval(
+        `class Foo {
+              const list = "Hello world!";
+              }`,
+        { parser: { version: 803 } },
+      ),
+    ).toMatchSnapshot();
+  });
 });