-
-
Notifications
You must be signed in to change notification settings - Fork 499
Description
Issue 1: oicd
string
When upgrading to 4.4.9 I was experiencing a breaking change due to the OIDC modifications. Specifically the "oicd" > "oidc" change in the hardcoded string CLIENTREGISTRATION_NAME
(a528295#diff-02b4b5eca0c6264d2f2a7bb6298d02fe1e1ff554af313fdd5a198a46031a57a3R66). As the redirectUrl
is configured in a third party application we don't have direct control over that configuration, which makes any modification a difficult one.
I'm fine with the change, but it might need to be signalled as a breaking one in the change notes upon release, to prevent additional headaches :).
Issue 2: new OIDC class is expected to be used / configured
The class OAuth2AuthorizedClientManager
is expected to be configured as a bean, which might be a breaking change to people that are upgrading their current configuration. I'm not sure what to do myself here, the related PR did not give information on it. However, when making the Autowired variables optional everything works as expected in our case. This could be signalled as well (or additional upgrade tips could be given?): Informatievlaanderen@0188c91