Skip to content

Commit 5a9993c

Browse files
authored
#156 rebuild and test Dockerfile and notebooks - minor updates scripts (#161)
* #156 rebuild and test Dockerfile and notebooks - minor updates scripts * #156 remove build.log file from GH
1 parent efd2674 commit 5a9993c

File tree

4 files changed

+13
-2162
lines changed

4 files changed

+13
-2162
lines changed

workshop/docker-compose-services.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
version: "3"
2-
31
# Optional services - not for regular workshop like FOSS4G.
42
# start: docker-compose -f docker-compose-services.yml up -d
53
# stop: docker-compose -f docker-compose-services.yml stop
@@ -29,6 +27,6 @@ services:
2927

3028
networks:
3129
default:
32-
external:
33-
# Provided by and shared with the Workshop Jupyter Notebook.
34-
name: workshop_default
30+
# Provided by and shared with the Workshop Jupyter Notebook.
31+
name: workshop_default
32+
external: true

workshop/docker-compose.yml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
version: "3"
2-
31
services:
42
jupyter:
53
container_name: geopython-workshop-jupyter
@@ -8,3 +6,11 @@ services:
86
- 8888:8888
97
volumes:
108
- ./jupyter/content:/jupyter/content:rw
9+
#networks:
10+
# default:
11+
# # Provided by and shared with the services; create and
12+
# # enable only when using docker-compose-services.yml as well via:
13+
# # docker network create --driver bridge workshop_default
14+
# # this is not part of the standard workshop agenda/chapters
15+
# name: workshop_default
16+
# external: true

workshop/geopython-workshop-ctl.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,8 @@ elif [ $1 == "url" ]; then
4848
openapp="cmd /c start"
4949
fi
5050

51-
url=$(docker logs geopython-workshop-jupyter 2>&1 | grep " or http" | sed 's/ or //')
51+
# Filter the URL from the log output
52+
url=$(docker logs geopython-workshop-jupyter 2>&1 | grep "http://127.0.0.1" | tail -n 1 | xargs)
5253
if [ -z ${url} ]; then
5354
echo "workshop not started"
5455
echo "did you start the workshop? (i.e. bash $0 start)"

0 commit comments

Comments
 (0)