-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validate pydantic version when testing on Debian #1766
Comments
|
The current version in Debian |
Sorry @pantierra, looking at the v1.10.17 tag in the field class I do see a |
This Issue has been inactive for 90 days. As per RFC4, in order to manage maintenance burden, it will be automatically closed in 7 days. |
Debian now has Pydantic 2.9.2. Can we change pygeoapi to use the |
Thanks @EdwardBetts, I’m going to push a PR really soon |
This #1941 should close the issue. However, Ubuntu Oracular and above are supporting v2 https://launchpad.net/ubuntu/+source/pydantic. @kalxas thoughts? Should we have a Dockerfile version of this OS release? |
I would wait for pydantic 2.x to hit the next Ubuntu LTS before moving |
It feels like a chicken-and-egg situation. If we follow the dependencies that are in the latest Debian ( |
Is the goal to include pygeoapi in Debian on the next stable release? |
Let's discuss at the next pygeoapi meeting on 2025-02-28. |
My goal is to get it included in Debian, regardless of specific release timelines. If it were added to Debian’s |
We discussed this at today's pygeoapi meeting. pygeoapi inclusion in Debian is of value and importance. We also need to consider the importance of Ubuntu LTS to the community at large. We also discussed that a safe strategy would be to have version checks in the pygeoapi pydantic codepaths to be able to shim between v1 and v2. @francbartoli is this possible to update for #1941? I believe @webb-ben has done some work in this direction. |
@tomkralidis thanks for the discussion and sorry I couldn't join. |
@francbartoli good point. I propose we do this starting with 0.20.0 |
I agree @kalxas, it looks like a good plan |
What we also need to think is the "version" reported by master. |
Assigning another version to master branch sounds good to me |
Perhaps just "master" would do it |
Perhaps master can report "1.0-dev" |
As discussed at FOSS4G Europe 2024 with @EdwardBetts and @pantierra (in support of pygeoapi on Debian):
https://hachyderm.io/@edward/112728302761775798
@EdwardBetts @pantierra can you confirm the Debian version?
On jammy (our current baseline):
And a small script to test/reproduce (Debian sid):
docker run -it debian:sid apt update -y && apt install python3-pydantic
The text was updated successfully, but these errors were encountered: