Making try_new methods for geometry subtypes pub(crate) and remove unused new methods

Author: Kontinuation

src/reader/geometry_collection.rs

@@ -23,7 +23,11 @@ impl<'a> GeometryCollection<'a> {
     /// Construct a new GeometryCollection from a WKB buffer.
     ///
     /// This will parse the WKB header and extract all contained geometries.
-    pub fn try_new(buf: &'a [u8], byte_order: Endianness, dim: Dimension) -> WkbResult<Self> {
+    pub(crate) fn try_new(
+        buf: &'a [u8],
+        byte_order: Endianness,
+        dim: Dimension,
+    ) -> WkbResult<Self> {
         let mut offset = 0;
         let has_srid = has_srid(buf, byte_order, offset)?;
         if has_srid {

src/reader/linearring.rs

@@ -40,20 +40,10 @@ pub struct LinearRing<'a> {
 }
 
 impl<'a> LinearRing<'a> {
-    /// Construct a new LinearRing from a WKB buffer.
-    ///
-    /// # Panics
-    ///
-    /// This will panic if the WKB buffer is invalid. For fallible parsing, use
-    /// [`try_new`](Self::try_new) instead.
-    pub fn new(buf: &'a [u8], byte_order: Endianness, offset: u64, dim: Dimension) -> Self {
-        Self::try_new(buf, byte_order, offset, dim).unwrap()
-    }
-
     /// Construct a new LinearRing from a WKB buffer.
     ///
     /// This will parse the number of points and validate the buffer length.
-    pub fn try_new(
+    pub(crate) fn try_new(
         buf: &'a [u8],
         byte_order: Endianness,
         offset: u64,

src/reader/linestring.rs

@@ -28,20 +28,10 @@ pub struct LineString<'a> {
 }
 
 impl<'a> LineString<'a> {
-    /// Construct a new LineString from a WKB buffer.
-    ///
-    /// # Panics
-    ///
-    /// This will panic if the WKB buffer is invalid. For fallible parsing, use
-    /// [`try_new`](Self::try_new) instead.
-    pub fn new(buf: &'a [u8], byte_order: Endianness, offset: u64, dim: Dimension) -> Self {
-        Self::try_new(buf, byte_order, offset, dim).unwrap()
-    }
-
     /// Construct a new LineString from a WKB buffer.
     ///
     /// This will parse the WKB header and validate the buffer length.
-    pub fn try_new(
+    pub(crate) fn try_new(
         buf: &'a [u8],
         byte_order: Endianness,
         mut offset: u64,

src/reader/multilinestring.rs

@@ -21,11 +21,6 @@ pub struct MultiLineString<'a> {
 }
 
 impl<'a> MultiLineString<'a> {
-    #[allow(dead_code)]
-    pub(crate) fn new(buf: &'a [u8], byte_order: Endianness, dim: Dimension) -> Self {
-        Self::try_new(buf, byte_order, dim).unwrap()
-    }
-
     pub(crate) fn try_new(
         buf: &'a [u8],
         byte_order: Endianness,

src/reader/multipoint.rs

@@ -22,11 +22,6 @@ pub struct MultiPoint<'a> {
 }
 
 impl<'a> MultiPoint<'a> {
-    #[allow(dead_code)]
-    pub(crate) fn new(buf: &'a [u8], byte_order: Endianness, dim: Dimension) -> Self {
-        Self::try_new(buf, byte_order, dim).unwrap()
-    }
-
     pub(crate) fn try_new(
         buf: &'a [u8],
         byte_order: Endianness,

src/reader/multipolygon.rs

@@ -21,11 +21,6 @@ pub struct MultiPolygon<'a> {
 }
 
 impl<'a> MultiPolygon<'a> {
-    #[allow(dead_code)]
-    pub(crate) fn new(buf: &'a [u8], byte_order: Endianness, dim: Dimension) -> Self {
-        Self::try_new(buf, byte_order, dim).unwrap()
-    }
-
     pub(crate) fn try_new(
         buf: &'a [u8],
         byte_order: Endianness,

src/reader/polygon.rs

@@ -21,20 +21,10 @@ pub struct Polygon<'a> {
 }
 
 impl<'a> Polygon<'a> {
-    /// Construct a new Polygon from a WKB buffer.
-    ///
-    /// # Panics
-    ///
-    /// This will panic if the WKB buffer is invalid. For fallible parsing, use
-    /// [`try_new`](Self::try_new) instead.
-    pub fn new(buf: &'a [u8], byte_order: Endianness, offset: u64, dim: Dimension) -> Self {
-        Self::try_new(buf, byte_order, offset, dim).unwrap()
-    }
-
     /// Construct a new Polygon from a WKB buffer.
     ///
     /// This will parse the WKB header and extract all linear rings.
-    pub fn try_new(
+    pub(crate) fn try_new(
         buf: &'a [u8],
         byte_order: Endianness,
         mut offset: u64,