Fix #11146 Edit permission to everyone should not be set (#11150) (#11171)

Author: allyoucanmap

web/client/plugins/ResourcesCatalog/components/Permissions.jsx

@@ -265,7 +265,7 @@ function Permissions({
                                 <PermissionsRow
                                     {...entry}
                                     onChange={editing ? handleUpdateEntry.bind(null, entry.id) : null}
-                                    options={permissionOptions?.default}
+                                    options={permissionOptions?.[`entry.name.${entry.name}`] || permissionOptions?.default}
                                 >
                                     {entry.permissions !== 'owner' && editing ?
                                         <>

web/client/plugins/ResourcesCatalog/components/PermissionsRow.jsx

@@ -33,6 +33,7 @@ function PermissionsRow({
         ? (
             <Select
                 clearable={clearable}
+                disabled={options?.length < 2}
                 options={options.map(({ value, labelId, label }) => ({ value, label: label ? <span>{label}</span> : <Message msgId={labelId} />}))}
                 value={permissions}
                 onChange={(option) => onChange({ permissions: option?.value || '' })}

web/client/plugins/ResourcesCatalog/components/__tests__/Permissions-test.jsx

@@ -27,4 +27,51 @@ describe('Permissions component', () => {
         const permissions = document.querySelector('.ms-permissions');
         expect(permissions).toBeTruthy();
     });
+
+    it('should provide different list of permission based on entry name', () => {
+        ReactDOM.render(<Permissions
+            editing
+            compactPermissions={{
+                entries: [
+                    {
+                        type: 'group',
+                        id: 1,
+                        name: 'everyone',
+                        permissions: 'view'
+                    },
+                    {
+                        type: 'group',
+                        id: 2,
+                        name: 'custom-group',
+                        permissions: 'view'
+                    }
+                ]
+            }}
+            permissionOptions={{
+                'entry.name.everyone': [
+                    {
+                        value: 'view',
+                        labelId: 'resourcesCatalog.viewPermission'
+                    }
+                ],
+                'default': [
+                    {
+                        value: 'view',
+                        labelId: 'resourcesCatalog.viewPermission'
+                    },
+                    {
+                        value: 'edit',
+                        labelId: 'resourcesCatalog.editPermission'
+                    }
+                ]
+            }}
+        />, document.getElementById('container'));
+        const permissions = document.querySelector('.ms-permissions');
+        expect(permissions).toBeTruthy();
+        const permissionsRows = document.querySelectorAll('.ms-permissions-row');
+        expect(permissionsRows.length).toBe(2);
+        expect([...permissionsRows].map(row => row.innerText)).toEqual(['everyone\nresourcesCatalog.viewPermission', 'custom-group\nresourcesCatalog.viewPermission']);
+        const disabled = permissionsRows[0].querySelector('.is-disabled');
+        expect(disabled).toBeTruthy();
+    });
 });

web/client/plugins/ResourcesCatalog/containers/ResourcePermissions.jsx

@@ -118,6 +118,12 @@ function ResourcePermissions({
                 });
             }}
             permissionOptions={{
+                'entry.name.everyone': [
+                    {
+                        value: 'view',
+                        labelId: 'resourcesCatalog.viewPermission'
+                    }
+                ],
                 'default': [
                     {
                         value: 'view',