Skip to content

Commit f5a3b92

Browse files
authored
Update default dependency for gtest. (protocolbuffers#7907)
The gtest source was changed in protocolbuffers#7237 on an opt-in basis, and has been released since 3.12.0. The comments state that the default should change in 3.13.0, but that didn't quite happen. This change does flip the default, and updates comments to say 3.14.0.
1 parent ad29d40 commit f5a3b92

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

BUILD

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ exports_files(["LICENSE"])
1414
# build configuration
1515
################################################################################
1616

17+
# TODO(yannic): Remove in 3.14.0.
1718
string_flag(
1819
name = "incompatible_use_com_google_googletest",
19-
# TODO(yannic): Flip to `true` for `3.13.0`.
20-
build_setting_default = "false",
20+
build_setting_default = "true",
2121
values = ["true", "false"]
2222
)
2323

WORKSPACE

+2-2
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,13 @@ bind(
2929
actual = "//util/python:python_headers",
3030
)
3131

32-
# TODO(yannic): Remove in 3.13.0.
32+
# TODO(yannic): Remove in 3.14.0.
3333
bind(
3434
name = "gtest",
3535
actual = "@com_google_googletest//:gtest",
3636
)
3737

38-
# TODO(yannic): Remove in 3.13.0.
38+
# TODO(yannic): Remove in 3.14.0.
3939
bind(
4040
name = "gtest_main",
4141
actual = "@com_google_googletest//:gtest_main",

0 commit comments

Comments
 (0)