Skip to content

Commit e76d7b8

Browse files
committed
BRD-20938 fix rubocop errors
1 parent a2606c3 commit e76d7b8

File tree

2 files changed

+7
-11
lines changed

2 files changed

+7
-11
lines changed

lib/scorm_engine/api/endpoints/courses.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,24 +35,24 @@ def get_courses(options = {})
3535
result = Enumerator.new do |enum|
3636
if single_course_id
3737
# Single course endpoint returns course data directly
38-
if response.success? && response.raw_response.body.is_a?(Hash)
38+
if response.success? && response.raw_response.body.is_a?(Hash) # rubocop:disable Style/IfUnlessModifier
3939
enum << ScormEngine::Models::Course.new_from_api(response.raw_response.body)
4040
end
4141
else
4242
# Multiple courses endpoint returns array in "courses" key
4343
loop do
4444
break unless response.success? && response.raw_response.body.is_a?(Hash)
45-
45+
4646
courses = response.raw_response.body["courses"]
4747
break unless courses.is_a?(Array)
48-
48+
4949
courses.each do |course|
5050
enum << ScormEngine::Models::Course.new_from_api(course)
5151
end
52-
52+
5353
more_url = response.raw_response.body["more"]
5454
break if more_url.nil?
55-
55+
5656
response = get(more_url)
5757
end
5858
end

lib/scorm_engine/models/course_import.rb

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,7 @@ def self.new_from_api(options = {})
3434
this.status = (options["status"] || import_result["status"])&.upcase
3535
this.parser_warnings = import_result["parserWarnings"]
3636

37-
if import_result.key?("course")
38-
this.course = Course.new_from_api(import_result["course"])
39-
end
37+
this.course = Course.new_from_api(import_result["course"]) if import_result.key?("course")
4038

4139
elsif options.keys == ["result"]
4240
# Initial import response (legacy format: {"result" => "job-id"})
@@ -49,9 +47,7 @@ def self.new_from_api(options = {})
4947
this.status = options["status"]&.upcase
5048
this.parser_warnings = options["parserWarnings"]
5149

52-
if options.key?("course")
53-
this.course = Course.new_from_api(options["course"])
54-
end
50+
this.course = Course.new_from_api(options["course"]) if options.key?("course")
5551
end
5652

5753
this

0 commit comments

Comments
 (0)