Skip to content

Commit 925ab32

Browse files
atrakhConvex, Inc.
authored and
Convex, Inc.
committed
cleanup rendering of github identity (#37946)
GitOrigin-RevId: a1d38cfec666837ce4a649f17720ac37b351e521
1 parent d70e7b9 commit 925ab32

File tree

3 files changed

+8
-1
lines changed

3 files changed

+8
-1
lines changed

npm-packages/dashboard/dashboard-openapi.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4013,6 +4013,12 @@
40134013
"null"
40144014
]
40154015
},
4016+
"nickname": {
4017+
"type": [
4018+
"string",
4019+
"null"
4020+
]
4021+
},
40164022
"username": {
40174023
"type": [
40184024
"string",

npm-packages/dashboard/src/components/profile/ConnectedIdentities.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ export function IdentityDisplayName({
222222
if (provider === "google-oauth2") {
223223
main = profileData.email ?? undefined;
224224
} else if (provider === "github") {
225-
main = profileData.username ?? undefined;
225+
main = profileData.username ?? profileData.nickname ?? undefined;
226226
} else if (provider === "vercel") {
227227
const [account, u] = userId.split(":user:");
228228
const accountId = account.split(":")[1];

npm-packages/dashboard/src/generatedApi.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1832,6 +1832,7 @@ export interface components {
18321832
ProfileData: {
18331833
email?: string | null;
18341834
name?: string | null;
1835+
nickname?: string | null;
18351836
username?: string | null;
18361837
};
18371838
ProfileEmailArgs: {

0 commit comments

Comments
 (0)